refactor: post/put/patch asset reviews #1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR from a fork cannot access secrets needed for workflows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1098
Resolves #985
Refactors the controller and MySQL service methods for Asset Review POST, PUT, and PATCH endpoints:
POST /collections/{collectionId}/reviews/{assetId}PATCH /collections/{collectionId}/reviews/{assetId}/{ruleId}PUT /collections/{collectionId}/reviews/{assetId}/{ruleId}The revised approach performs most request validation logic in the MySQL service.