Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove unlimited history records option, set new cap to 15, new default value to 5 #1319

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

cd-rite
Copy link
Collaborator

@cd-rite cd-rite commented Jul 10, 2024

Resolves: #1299

cd-rite added 3 commits June 6, 2024 16:29
…lection Settings that specify a history.maxReviews >15 or = -1 to 15. Does not delete history as part of operation. History records will be pruned to new limit on subsequent review updates.
@cd-rite cd-rite requested a review from csmig July 10, 2024 17:07
Copy link

Quality Gate Passed Quality Gate passed for 'nuwcdivnpt_stig-manager-client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'nuwcdivnpt_stig-manager-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@csmig csmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a data set having >15 history records for a review and verified that history was pruned as intended when updating that review. Also tested that changes to the history setting were being correctly applied upon the next review update.

@cd-rite cd-rite merged commit 3ae875d into main Jul 15, 2024
12 checks passed
@cd-rite cd-rite deleted the 2024-06-06-review-history-cap branch August 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for "unlimited" review history records, set max UI option to 15, default to 5
2 participants