feat: new appinfo implementation

.github/workflows/api-audit-test-coverage-response.yml

@@ -29,6 +29,7 @@ env:
   STIGMAN_SWAGGER_SERVER: http://localhost:64001/api
   STIGMAN_SWAGGER_REDIRECT: http://localhost:64001/api-docs/oauth2-redirect.html
   STIGMAN_DEV_RESPONSE_VALIDATION: logOnly
+  STIGMAN_EXPERIMENTAL_APPDATA: 'true'
   NODE_V8_COVERAGE: /home/runner/work/stig-manager/stig-manager/api/source/coverage/tmp/
 
 permissions:

.github/workflows/api-container-tests.yml

@@ -65,6 +65,7 @@ jobs:
           -e STIGMAN_DB_PASSWORD=stigman \
           -e STIGMAN_API_AUTHORITY=http://127.0.0.1:8080/auth/realms/stigman \
           -e STIGMAN_DEV_RESPONSE_VALIDATION=logOnly \
+          -e STIGMAN_EXPERIMENTAL_APPDATA=true \
           ${{ matrix.container.name }}
 
       - name: Install test dependencies

api/source/controllers/Operation.js

@@ -33,6 +33,9 @@ module.exports.setConfigurationItem = async function setConfigurationItem (req,
 
 module.exports.getAppData = async function getAppData (req, res, next) {
   try {
+    if (!config.experimental.appData) {
+      throw new SmError.NotFoundError('endpoint disabled, to enable set STIGMAN_EXPERIMENTAL_APPDATA=true')
+    }
     let elevate = req.query.elevate
     if ( elevate ) {
       let collections = await Collection.exportCollections( ['grants', 'labels', 'stigs'], elevate, req.userObject )
@@ -81,6 +84,9 @@ module.exports.getAppData = async function getAppData (req, res, next) {
 
 module.exports.replaceAppData = async function replaceAppData (req, res, next) {
   try {
+    if (!config.experimental.appData) {
+      throw new SmError.NotFoundError('endpoint disabled, to enable set STIGMAN_EXPERIMENTAL_APPDATA=true')
+    }
     req.noCompression = true
     let elevate = req.query.elevate
     let appdata
@@ -129,11 +135,11 @@ module.exports.getDefinition = async function getDefinition (req, res, next) {
   }
 }
 
-module.exports.getDetails = async function getDetails (req, res, next) {
+module.exports.getAppInfo = async function getAppInfo (req, res, next) {
   try {
     let elevate = req.query.elevate
     if ( elevate ) {
-      const response = await OperationService.getDetails()
+      const response = await OperationService.getAppInfo()
       res.json(response)
     }
     else {
@@ -144,3 +150,5 @@ module.exports.getDetails = async function getDetails (req, res, next) {
     next(err)
   }
 }
+
+module.exports.getDetails = module.exports.getAppInfo

api/source/index.js

@@ -130,7 +130,7 @@ app.use((err, req, res, next) => {
     })
   }
   // Expose selected error properties in the response
-  res.errorBody = { error: err.message, detail: err.detail, stack: err.stack}
+  res.errorBody = { error: err.message, code: err.code, detail: err.detail, stack: err.stack}
   if (!res._headerSent) {
     res.status(err.status || 500).header(err.headers).json(res.errorBody)
   }
@@ -224,6 +224,9 @@ const STIGMAN = {
           privileges: "${config.oauth.claims.privileges}",
           email: "${config.oauth.claims.email}"
         }
+    },
+    experimental: {
+      appData: "${config.experimental.appData}"
     }
   }
 }