feat: detailed status during web app bootstrap; handle token errors #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmig
changed the title
cd-rite
reviewed
Dec 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1447
init.jsandstigman.jswere updated to display concatenated status messages during the bootstrap phases 1) authorization, 2) app loading, and 3) initial API request for/user.OIDCProvider.jswas updated to throw on errors from thetokenendpoint. Also, the stored PKCE code verifier is now removed after being used for the token request. Before making the token request, OIDCProvider now checks if the stored code verifier exists. If not, it restarts the authorization phase by redirecting back to the base URL.These updates appear to handle the scenario where a user has bookmarked our authorization request while viewing the OP login page, and later uses this bookmark.
Handling of the API request to
/userwas not modified, it uses our common routine for making API requests which does not support retry rounds.Token inspection was not added because token issues should result in an API error response, which is already being displayed by the web app.