Skip to content

Add kl shampoo support to SOAP #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add kl shampoo support to SOAP #64

wants to merge 7 commits into from

Conversation

skyw
Copy link
Contributor

@skyw skyw commented Oct 17, 2025

No description provided.

skyw added 4 commits October 15, 2025 16:44
@skyw
add update_kronecker_factors_kl_shampoo function
e147f93 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
add update_kronecker_factors_kl_shampoo function
aa32df8 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
add kl shampoo option to Soap
f292a1a 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
add reference link
27039ce 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

skyw added 2 commits October 17, 2025 14:55
@skyw
update smoke test for soap
46de7b0 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
add smoke test for kl shampoo and fix bug
25200cc 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw skyw force-pushed the skyw/kl_shampoo_dev branch from b9357f8 to 25200cc Compare October 17, 2025 21:55
@skyw
Copy link
Contributor Author

skyw commented Oct 17, 2025

@mkhona-nvidia we need to think about how to test this.

mkhona-nvidia
mkhona-nvidia requested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@mkhona-nvidia mkhona-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: instead in the init make a kronecker_factor_update_fn and assign either update_kronecker_factors or update_kronecker_factors_kl_shampoo

need to think about how to deal with that extra argument eigenbasis_list

@mkhona-nvidia mkhona-nvidia mentioned this pull request Oct 17, 2025
Closed
@skyw
improve kronecker_factor_update_fn logic
fdf00bb 
Signed-off-by: Hao Wu <skyw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkhona-nvidia mkhona-nvidia mkhona-nvidia requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skyw @mkhona-nvidia