Skip to content

Conversation

pjin-nvidia
Copy link
Contributor

What does this PR do ?

Generation-related functionality accepts optional sampling params which overrides the default sampling params in the generation config. This may be useful e.g. for using different sampling params during validation than during training.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Peter Jin <pjin@nvidia.com>
Signed-off-by: Peter Jin <pjin@nvidia.com>
@pjin-nvidia pjin-nvidia force-pushed the pjin/sampling-params branch from a88381a to 662dd0d Compare October 6, 2025 21:36
Signed-off-by: Peter Jin <pjin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant