Clean up FusionDefinition::execute

[wujingyue]

No description provided.

[wujingyue]

!test

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 3b67d72)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

⚡ Recommended focus areas for review Logic Change The FusionDefinition::execute function has been refactored to use a lambda function find_user_schedule to retrieve the user schedule. This change may affect the logic of the function and requires careful review. auto find_user_schedule = [&]() -> const UserSchedule* { if (override_user_schedule) { return nullptr; } auto user_sched_id = fusionCache()->queryUserScheduleId(scheds, inputs); if (!user_sched_id.has_value()) { return nullptr; } auto device = getCommonDeviceCUDA(inputs, selected_device); NVF_CHECK( inputs.empty() || device > -1, "Inputs are not all on the same device or don't match selection!"); const UserSchedule& user_sched = fusionCache()->queryUserSchedule(scheds, user_sched_id.value(), device); return &user_sched; }; Potential Null Pointer The user_sched pointer is checked for null before being used, but it is not clear if this pointer can be null in all cases. Reviewers should verify that this pointer is properly initialized and handled. const auto* user_sched = find_user_schedule(); std::vector<at::Tensor> outputs; if (user_sched == nullptr) { outputs = scheds->auto_gen_schedules->runFusionWithInputs( inputs, std::nullopt, selected_device); } else { if (isProfilerEnabledWithCupti()) { FusionProfiler::start(); FusionProfiler::createSegments(1); } scheds->last_user_def_scheduled_ir = user_sched->scheduled_fusion.get(); scheds->last_user_def_executor = user_sched->executor.get(); if (user_sched->heuristic_params == nullptr) { // Manual schedule if (!user_sched->executor->isCompiled()) { user_sched->executor->compile( user_sched->scheduled_fusion.get(), inputs); } outputs = user_sched->executor->run(inputs); } else { // Automatic scheduler was used for UserSchedule. // Pass launch and compile params to compileFusion and runFusion. if (!user_sched->executor->isCompiled()) { user_sched->executor->compile( user_sched->scheduled_fusion.get(), KernelArgumentHolder::createKernelArgumentHolder( inputs, getCommonDeviceCUDA(inputs)), user_sched->heuristic_params->lparams, user_sched->heuristic_params->cparams, user_sched->heuristic_params->scheduler_type); } outputs = user_sched->executor->run( inputs, user_sched->heuristic_params->lparams, user_sched->heuristic_params->cparams); } if (isProfilerEnabledWithCupti()) { FusionProfiler::segment(0).scheduler("user"); FusionProfiler::stop(); if (isProfilerPrintingEnabled()) { debug() << FusionProfiler::profile(); } } }

[wujingyue]

!test

[rdspring1]

LGTM