Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemoryType::Tensor #3780

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add MemoryType::Tensor #3780

merged 1 commit into from
Jan 29, 2025

Conversation

zasdfgbnm
Copy link
Collaborator

Extracted from #3755 to make it easier to review.

@zasdfgbnm
Copy link
Collaborator Author

!test

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
⚡ Recommended focus areas for review

Not Implemented

The MemoryType::Tensor case is not implemented yet and throws an exception.

case MemoryType::Tensor: {
  NVF_THROW("Not implemented yet");
  break;
}
Unhandled Memory Type

The MemoryType::Tensor case is not handled and does not update the summary.

case MemoryType::Tensor:
  break;

Copy link
Collaborator

@rdspring1 rdspring1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, I expected I needed a lot more effort to review based the title of the PR.

@zasdfgbnm zasdfgbnm merged commit 0f1ba30 into main Jan 29, 2025
49 of 51 checks passed
@zasdfgbnm zasdfgbnm deleted the MemoryType--Tensor branch January 29, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants