Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use arch-specific PTX on Blackwell #3784

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Use arch-specific PTX on Blackwell #3784

merged 1 commit into from
Jan 29, 2025

Conversation

zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Jan 29, 2025 •
edited
Loading

Minor change extracted from: #3755

@zasdfgbnm
Copy link
Collaborator Author

!test

@zasdfgbnm zasdfgbnm requested a review from naoyam January 29, 2025 01:38
@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
⚡ Recommended focus areas for review

Arch-Specific PTX

The PR introduces arch-specific PTX usage for major version 9 and above. Reviewer should verify the correctness of this change and ensure it doesn't break compatibility with other architectures.

if (major >= 9) {
  // Use 90a and 100a so that arch-specific PTX is available
  compute += "a";
}

naoyam
naoyam approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zasdfgbnm zasdfgbnm merged commit a470821 into main Jan 29, 2025
42 of 45 checks passed
@zasdfgbnm zasdfgbnm deleted the arch-ptx branch January 29, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoyam naoyam naoyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zasdfgbnm @naoyam