Skip to content

[None][chore] Add failed cases into waives.txt#12047

Open
xinhe-nv wants to merge 2 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312
Open

[None][chore] Add failed cases into waives.txt#12047
xinhe-nv wants to merge 2 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/post_update_waive_20260310_LLM_FUNCTION_CLUSTER_TEST_1312

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Mar 9, 2026

waive failed cases.

Summary by CodeRabbit

  • Chores
    • Updated internal test execution configurations to manage test expectations across distributed model serving and data type handling scenarios.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv marked this pull request as ready for review March 10, 2026 07:26
@xinhe-nv xinhe-nv enabled auto-merge (squash) March 10, 2026 07:26
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0513912e-acb9-4112-bb78-51532215837d

📥 Commits

Reviewing files that changed from the base of the PR and between 39d294b and 407b701.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This pull request adds seven new SKIP entries to the test waives list, marking specific failing test cases for Nemotron, DeepSeek, and GPTOSS models as waived. The entries target multi-GPU and distributed serving test scenarios.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Added 7 SKIP entries for failing test cases across TestNemotronV3Super, TestDeepSeekV3Lite, and TestGPTOSS test classes, covering multi-GPU dtype and model reuse scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing critical sections from the template including detailed explanation, test coverage justification, and proper PR checklist completion. Expand the description to include: why these specific test cases are being waived, what test coverage validates this change, and completion of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding failed test cases to the waives.txt file, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38403 [ run ] triggered by Bot. Commit: 407b701 Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants