Skip to content

[https://nvbugs/5963896][fix] Remove test test_visual_gen_quickstart on A10#12048

Open
chang-l wants to merge 3 commits intoNVIDIA:mainfrom
chang-l:remove-A10-test-visual-gen
Open

[https://nvbugs/5963896][fix] Remove test test_visual_gen_quickstart on A10#12048
chang-l wants to merge 3 commits intoNVIDIA:mainfrom
chang-l:remove-A10-test-visual-gen

Conversation

@chang-l
Copy link
Collaborator

@chang-l chang-l commented Mar 9, 2026

Summary by CodeRabbit

  • Chores
    • Updated test configuration by removing test list entries and associated waivers.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@chang-l
Copy link
Collaborator Author

chang-l commented Mar 9, 2026

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

📝 Walkthrough

Walkthrough

Removed test entries for examples/test_visual_gen.py::test_visual_gen_quickstart from PyTorch pre-merge test lists and corresponding waiver configuration, eliminating this test from scheduled execution and skip status tracking.

Changes

Cohort / File(s) Summary
Test Configuration & Waivers
tests/integration/test_lists/test-db/l0_a10.yml, tests/integration/test_lists/test-db/l0_sanity_check.yml, tests/integration/test_lists/waives.txt
Removed examples/test_visual_gen.py::test_visual_gen_quickstart from test execution lists and deleted corresponding skip waiver entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty with only template placeholders and an unchecked checklist. No actual description, test coverage details, or explanation of changes is provided. Fill in the Description section explaining why the test_visual_gen_quickstart test is being removed from A10, and add Test Coverage details documenting what tests validate this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing a specific test from A10, directly matching the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38313 [ run ] triggered by Bot. Commit: d5f259c Link to invocation

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@chang-l chang-l requested a review from a team as a code owner March 9, 2026 18:53
@tensorrt-cicd
Copy link
Collaborator

PR_Github #38313 [ run ] completed with state SUCCESS. Commit: d5f259c
/LLM/main/L0_MergeRequest_PR pipeline #29690 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@chang-l
Copy link
Collaborator Author

chang-l commented Mar 9, 2026

/bot run

1 similar comment
@chang-l
Copy link
Collaborator Author

chang-l commented Mar 9, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38330 [ run ] triggered by Bot. Commit: 2959f89 Link to invocation

Copy link
Member

@zhenhuaw-me zhenhuaw-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping fix this.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38330 [ run ] completed with state SUCCESS. Commit: 2959f89
/LLM/main/L0_MergeRequest_PR pipeline #29706 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chang-l
Copy link
Collaborator Author

chang-l commented Mar 10, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38370 [ run ] triggered by Bot. Commit: 2959f89 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38370 [ run ] completed with state SUCCESS. Commit: 2959f89
/LLM/main/L0_MergeRequest_PR pipeline #29737 completed with status: 'SUCCESS'

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants