Skip to content

Conversation

KivenChen
Copy link
Contributor

Description

Fixes #2206

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes

Add -DPython_SITEARCH to TE's CMake build args, as a supplement to existing "-DPython_INCLUDE_DIR", "-DPython_EXECUTABLE" etc.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable fix for #2206. I see that the cuDNN C++ frontend checks Python_SITEARCH here: https://github.com/NVIDIA/cudnn-frontend/blob/80a8e4af4d89d33a2c59d51fcf9fda1c9d368cd4/cmake/cuDNN.cmake#L5

The DCO check is failing, so can you first sign your commit? https://github.com/NVIDIA/TransformerEngine/blob/main/CONTRIBUTING.rst#sign-your-work

@timmoon10 timmoon10 added bug Something isn't working build Build system labels Oct 1, 2025
@ptrendx ptrendx requested a review from ksivaman October 2, 2025 19:38
Signed-off-by: Kiv Chen <sdckivenchen@gmail.com>
[Build] fix: python platlib path
@KivenChen KivenChen reopened this Oct 5, 2025
@KivenChen
Copy link
Contributor Author

Seems like a reasonable fix for #2206. I see that the cuDNN C++ frontend checks Python_SITEARCH here: NVIDIA/cudnn-frontend@80a8e4a/cmake/cuDNN.cmake#L5

The DCO check is failing, so can you first sign your commit? main/CONTRIBUTING.rst#sign-your-work

Hi @timmoon10, the DCO check is now passing and the PR is ready.

Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

ksivaman commented Oct 5, 2025

/te-ci

@ksivaman ksivaman merged commit 56e2fed into NVIDIA:main Oct 6, 2025
43 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build TE: uv-installed cuDNN library not found
3 participants