feat:rack_manager.proto update for nvswitch#127
Open
narasimhan321 wants to merge 26 commits intoNVIDIA:mainfrom
Open
feat:rack_manager.proto update for nvswitch#127narasimhan321 wants to merge 26 commits intoNVIDIA:mainfrom
narasimhan321 wants to merge 26 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Narasimhan Venkadeswaran <nvenkadeswar@nvenkadeswar.nvidia.com>
narasimhan321
force-pushed
the
rms-nvswitch-integration-proto-changes
branch
from
312f421 to
4760a7c
Compare
wminckler
reviewed
Jan 30, 2026
crates/rpc/proto/rack_manager.proto
Outdated
| RestartClusterAppCommand restart_cluster_app = 10; | ||
| CheckNmxGrpcStatusCommand check_nmx_grpc_status = 11; | ||
| ConfigureSwitchGnmiServiceCommand configure_switch_gnmi_service = 12; | ||
| ConfigureSwitchNmxcCommand configure_switch_nmxc = 13; |
Contributor
There was a problem hiding this comment.
I don't think this is backwards compatible (I'm not really sure what this does to a "oneof" proto) and therefor would be a breaking change
Contributor
There was a problem hiding this comment.
Thee's no prior version of RMS released or deployed, so we're currently able to do this since its the initial implementation of the rack manager grpc api. Of course once the first release of RMS is done, then backward compatibility of the grpc api will be mandatory.
chet
reviewed
Jan 31, 2026
crates/rpc/proto/rack_manager.proto
Outdated
| } | ||
|
|
||
| message ConfigureSwitchGnmiServiceResponse { | ||
| string result_json = 1; // JSON string containing result |
Contributor
There was a problem hiding this comment.
This might be a bit of extra work, but would you be interested in expressing the JSON structure in protobuf form as well? Then we could have nice From implementations to translate to/from the the ::rpc type.
Contributor
|
What's the goal of this PR? This is just updating a .proto file but no code... nothing is effectively going to happen once this merges, unless I'm missing something? Can we put off merging proto changes until we have some code that will actually use it? Because then we'll have a better idea of what the "correct" protobuf api is for this stuff, since some code will actually be using it. Prior to that this is all just guesswork... there could be mistakes in this code and we wouldn't be able to tell. |
Contributor
@narasimhan321, can you add the other changes in carbide-core too that utilize these APIs in RMS. |
…s well. (#124) ## Description Fix get_dpf_state to accept only host ids including predicted hosts as well. The current check ignores the predicted hosts, which is wrong behaviour. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ x ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ x ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: abhi <abvarshney@nvidia.com>
…(#86) ## Description Add DPF based DPU provisioning support to the machine state machine. Including initial ingestion, re-provisioning, and force-delete. This completes the milestone 1 changes for DPF integration feature. ## Type of Change <!-- Check one that best describes this PR --> - [ x ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ x ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: abhi <abvarshney@nvidia.com> Signed-off-by: abvarshney-nv <abvarshney@nvidia.com>
…h DPUs Updates the DPUs DHCP server to serve the golan pxe binary instead of the snponly binary. This allows PXE to use the bluefield driver and avoid internal errors within the pxe client. Note that carbide renames the snponly binary to be ipxe.efi when building the x86 build artifacts. x86 host changes: snponly -> golan arm host changes: ipxe -> golan This also adds the ability to set the booturl for both x86 and arm hosts. Because this updates the DPU DHCP server config, this has no effect on non-dpu hosts ## Description <!-- Describe what this PR does --> ## Type of Change <!-- Check one that best describes this PR --> - [X] **Add** - New feature or capability - [X] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) FORGE-5259: ## Breaking Changes - [ ] This PR contains breaking changes ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [X] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance -->
## Description Another PR is trying to parallelize some of the deprovisioning calls, but it's making us use tokio::spawn_blocking because the actual commands are using blocking std::process::Command. Using the tokio one makes it work properly with tokio tasks without needing spawn_blocking. While we're at it, don't naively split commands on whitespace, make callers be explicit about what the arguments are, to avoid issues if any of the arguments themselves have spaces. (Not that we necessarily have any untrusted data going to these commands, but it's worth avoiding anyway.) ## Type of Change - [ ] **Add** - New feature or capability - [X] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes This is untested, I don't have a great way of e2e testing scout, and the existing tests don't actually run any commands on purpose.
## Description Use dpf_enabled flag from host. DPUs dpf_flag is not used. Also keep dpf_enabled flag in sync with all DPUs. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ x ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance -->
Signed-off-by: Patrice Breton <pbreton@nvidia.com>
## Description - `event` fields are renamed to `state` - individual history entries are now consistently called `Record` instead of `Event` also moves some purely DB related helper structs from model to db modules. ## Type of Change - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Signed-off-by: Matthias Einwag <meinwag@nvidia.com>
## Description
Dell supports two endpoints for Jobs interface:
/redfish/v1/Managers/iDRAC.Embedded.1/Jobs/{job_id}
and
/redfish/v1/Managers/iDRAC.Embedded.1/Oem/Dell/Jobs/{job_id}
This change adds second endpoint to bmc-mock.
## Type of Change
- [x] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [x] **Internal** - Internal changes (refactoring, tests, docs, etc.)
## Related Issues (Optional)
## Breaking Changes
- [ ] This PR contains breaking changes
<!-- If checked above, describe the breaking changes and migration steps
-->
## Testing
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [x] No testing required (docs, internal refactor, etc.)
## Additional Notes
Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
## Description <!-- Describe what this PR does --> This PR updates calls from carbide to RMS to include Rack ID. This change enables RMS to associate nodes with Rack IDs and perform operations at a rack level scope. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Waiting on some local-dev fixes to test more thoroughly. Signed-off-by: anunna <anunna@nvidia.com>
## Description chore: parallelize scrabbing code so that Scout can secure erase the nvme devices asynchronously ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance -->
## Description This PR brings in the following changes from libredfish `v0.39.1`: - fix: don't capture parent tracing span in http requests by @poroh in NVIDIA/libredfish#30 - feat: further support for newer iDRAC BIOS/UEFI password configuration by @krish-nvidia in NVIDIA/libredfish#31 ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [x] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
## Description Changed so VPCPrefix API is now uses Status/Config/Metadata instead of flat values inside prefix, old fields are still read but deprecated, to be removed in the future. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> --------- Signed-off-by: ianisimov <ianisimov@nvidia.com>
## Description New HW-Health removed Hardware classification, this PR adds it back. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [x] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance -->
## Description Site explorer blindly requested chassis network adapters collection when it has information if collection present or not by NetworkAdapters navigation property. This change add check if NetworkAdapters property present in response before request and therefore reduces number of useless network requests. ## Type of Change - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
…#122) ## Description All of the other RMS components (including `PowerShelf` and `Switch`) have their own uniquely-typed UUIDs. Make sure we're doing the same for `RackId`. Includes: - The introduction of a `uuid::rack::RackId` in the `uuid` crate. - The introduction of a `common.RackId` in `common.proto`. - Updating various proto messages to use `common.RackId`. - Updating API calls throughout. - Updating the `carbide-admin-cli` to use it. - Updating object filtering. - Updating tests. Signed-off-by: Chet Nichols III <chetn@nvidia.com> ## Type of Change <!-- Check one that best describes this PR --> - [x] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Chet Nichols III <chetn@nvidia.com>
## Description If the DPU reports a different version number than previously, it is likely that the desired configurations have been applied and that therefore the state handler can make progress. Therefore we re-schedule the state handler for immediate execution. This should make wait states like WaitingForNetworkConfig shorer by half of the state handler iteration time (15s). ## Type of Change - [x] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Signed-off-by: Matthias Einwag <meinwag@nvidia.com>
… (#143)
## Description
This migrates the remaining typed UUID-based IDs that we had within the
`uuid` crate to all be a `TypedUuid`. This does NOT include
hardware-backed IDs like `MachineId`.
For those who don't know, `TypedUuid` provides strongly typed IDs for
all of the things we use IDs for throughout Carbide which are
UUID-derived. This includes benefits like:
- Ensuring type safety for database identifiers.
- Ensuring we're passing around the correct ID -- it's easy to make
mistakes when everything is just a `uuid::Uuid` and variable names
aren't well named.
- A layer of abstraction that makes UUID an implementation detail of how
the ID is computed.
- Lots of little conveniences for free that make working with IDs a lot
more simple (formatting, equality, hashing, `.into()` common use cases,
etc).
To make one, it's as simple as:
```
use carbide_uuid::typed_uuids::{TypedUuid, UuidSubtype};
pub struct SomeIdMarker;
impl UuidSubtype for SomeIdMarker {
// Used in Debug output.
const TYPE_NAME: &'static str = "SomeId";
// The database column name when using FromRow.
// Defaults to "id" if not specified.
// Override as needed.
const DB_COLUMN_NAME: &'static str = "some_id";
}
pub type SomeId = TypedUuid<SomeIdMarker>;
```
In any case, while I was in here, I also added a few things:
### 1. `new()` Constructor
```
// Before:
let id = SomeId::from(uuid::Uuid::new_v4());
// After:
let id = SomeId::new();
```
### 2. `offset()` Method
```
// Before:
let id1 = base_id;
let id2 = uuid::Uuid::from_u128(uuid::Uuid::from(base_id).as_u128() + 1).into();
let id3 = uuid::Uuid::from_u128(uuid::Uuid::from(base_id).as_u128() + 2).into();
// After:
let id1 = base_id;
let id2 = base_id.offset(1);
let id3 = base_id.offset(2);
```
### 3. `From<TypedUuid<T>> for String` Implementation
```
// Before:
let rpc_uuid: common::Uuid = uuid::Uuid::from(some_id).into();
let rpc_uuid: common::Uuid = some_id.to_string().into();
// After:
let rpc_uuid: common::Uuid = some_id.into();
```
...which also simplifies struct field assignments:
```
// Before:
rpc::SomeMessage {
id: some_id.to_string(),
}
// After:
rpc::SomeMessage {
id: some_id.into(),
}
```
### 4. Simplified Display in Format Strings
```
// Before:
assert!(thing, "error with id {}", uuid::Uuid::from(some_id));
// After:
assert!(thing, "error for id {}", some_id);
```
As a result, the resulting cleanup included:
- Replacing `SomeId::from(uuid::Uuid::new_v4())` with `SomeId::new()`.
- Replacing `uuid::Uuid::from(id).into()` with `id.into()`.
- Replacing `.to_string()` with `.into()` where target the type was
String.
- Removed a bunch of unnecessary `uuid::Uuid::from()` in format strings.
A bunch of super boilerplate tests were added to each ID as well. Maybe
that could be a macro?
Signed-off-by: Chet Nichols III <chetn@nvidia.com>
## Type of Change
<!-- Check one that best describes this PR -->
- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [x] **Internal** - Internal changes (refactoring, tests, docs, etc.)
## Related Issues (Optional)
<!-- If applicable, provide GitHub Issue. -->
## Breaking Changes
- [ ] This PR contains breaking changes
<!-- If checked above, describe the breaking changes and migration steps
-->
## Testing
<!-- How was this tested? Check all that apply -->
- [x] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)
## Additional Notes
<!-- Any additional context, deployment notes, or reviewer guidance -->
Signed-off-by: Chet Nichols III <chetn@nvidia.com>
## Description The measured boot logic in `api.rs` is already pretty slim/boilerplate as it is, but since we have a `handlers/` pattern with everything, take advantage of the existing `handlers::measured_boot` (which is only used for a couple of calls), and move everything else in there. Signed-off-by: Chet Nichols III <chetn@nvidia.com> ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [x] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Chet Nichols III <chetn@nvidia.com>
## Description Another step to support different platforms in BMC mock. In this chapter Chassis are fully generated by configuration received from machine info. ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [x] Integration tests added/updated - [ ] Manual testing performed - [x] No testing required (docs, internal refactor, etc.) ## Additional Notes Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
## Description This test seems to have started hanging forever some of the time, since we've moved to Github's CI. I'm not sure why it's happening, but we can add a timeout to part of the test that waits for a condition so that we can at least fail faster. While we're at it, delete all the old legacy ssh-console testing code, since legacy ssh-console is fully gone and not deployed anywhere. (It only existed to make sure new ssh-console and legacy had identical behavior.) ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [X] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [X] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes
…attern (#147) ## Description Refactors the rack-firmware command in the admin-cli from a single file to the standard module pattern used by other commands. ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Not 100% sure if this file was left loose during the merge intentionally, please let me know if that is the case!
## Description Removes fields that were never used and never populated ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [x] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Signed-off-by: Matthias Einwag <meinwag@nvidia.com>
## Description This change allows to configure carbide to emit metrics under an additional prefix that is configurable via setting `alt_metric_prefix`. The default prefix changes to `carbide_`. This seting allows to migrate dashboards and alerts that used the past prefix to `carbide_`. ## Type of Change - [x] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) FORGE-7344 ## Breaking Changes - [x] This PR contains breaking changes Operators should set an `alt_metric_prefix` in config files to retain legacy metrics ## Testing - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes Signed-off-by: Matthias Einwag <meinwag@nvidia.com>
## Description To be inline with NVIDIA/bare-metal-manager-core#151 ## Type of Change <!-- Check one that best describes this PR --> - [x] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance -->
narasimhan321
force-pushed
the
rms-nvswitch-integration-proto-changes
branch
from
2b5d327 to
7d2a766
Compare
Collaborator
|
@narasimhan321 please make sure you're adding the "Signed-off-By" header with |
Collaborator
|
And this seems like it's pulling in a bunch of unrelated commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
cargo build -p carbide-rpc
Finished
devprofile [unoptimized + debuginfo] target(s) in 0.49sAdditional Notes
None