feat(secrets): file and env backed providers#426
Open
FrankSpitulski wants to merge 1 commit intoNVIDIA:mainfrom
Open
feat(secrets): file and env backed providers#426FrankSpitulski wants to merge 1 commit intoNVIDIA:mainfrom
FrankSpitulski wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
FrankSpitulski
force-pushed
the
feat/secrets/file-provider
branch
from
d290b72 to
cc4d3a8
Compare
kensimon
approved these changes
Mar 3, 2026
FrankSpitulski
force-pushed
the
feat/secrets/file-provider
branch
from
cc4d3a8 to
cb5d545
Compare
Closes NVIDIA#357 FORGE-7854 Signed-off-by: fspitulski <fspitulski@nvidia.com>
FrankSpitulski
force-pushed
the
feat/secrets/file-provider
branch
from
cb5d545 to
01d456f
Compare
Contributor
Author
|
@kensimon rebased due to merge conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add in support for env and file backed secret reading. intended to be used with k8s/vault agent file secrets.
splits the vault provider into a reader and writer trait, using each trait where needed. on the read path, a chained reader is used allowing site wide secrets to be provided statically. if not provided still fall back to vault.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
bringing some attention to the env config loading. I kept the same pattern as was there before with vault configs to load from env on access. it seems like we should be loading from the regular config flow though.
Closes #357 FORGE-7854