fix(api): bump librms client to 0.0.5 w/ support for host mac and ip addresses#433
Open
chet wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(api): bump librms client to 0.0.5 w/ support for host mac and ip addresses#433chet wants to merge 1 commit intoNVIDIA:mainfrom
chet wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
d2c9480 to
2e32b89
Compare
Matthias247
reviewed
Mar 3, 2026
Matthias247
approved these changes
Mar 3, 2026
kensimon
reviewed
Mar 4, 2026
…addresses This pulls in a couple of downstream changes to support the 0.0.5 client, including setting the Vault path for switches (which is actually going to only be a temporary thing, but we still need it for the interim), and passing through the IP and MAC address to node registration (which is also going to actually be something we eventually move away from, but still need it for the interim).
2e32b89 to
3920c98
Compare
kensimon
approved these changes
Mar 4, 2026
kensimon
reviewed
Mar 4, 2026
Comment on lines
+775
to
+787
| let new_node_info = NewNodeInfo { | ||
| rack_id: rack_id.to_string(), | ||
| node_id: power_shelf_id.to_string(), | ||
| mac_address: expected_shelf.bmc_mac_address.to_string(), | ||
| ip_address: explored_endpoint.address.to_string(), | ||
| port: 443, | ||
| username: None, | ||
| password: None, | ||
| r#type: Some(RmsNodeType::Powershelf.into()), | ||
| vault_path: String::new(), | ||
| host_ip_addresses: vec![], | ||
| host_mac_addresses: vec![], | ||
| }; |
Contributor
There was a problem hiding this comment.
BTW you can use Default::default() here (not that it really matters)
Suggested change
| let new_node_info = NewNodeInfo { | |
| rack_id: rack_id.to_string(), | |
| node_id: power_shelf_id.to_string(), | |
| mac_address: expected_shelf.bmc_mac_address.to_string(), | |
| ip_address: explored_endpoint.address.to_string(), | |
| port: 443, | |
| username: None, | |
| password: None, | |
| r#type: Some(RmsNodeType::Powershelf.into()), | |
| vault_path: String::new(), | |
| host_ip_addresses: vec![], | |
| host_mac_addresses: vec![], | |
| }; | |
| let new_node_info = NewNodeInfo { | |
| rack_id: rack_id.to_string(), | |
| node_id: power_shelf_id.to_string(), | |
| mac_address: expected_shelf.bmc_mac_address.to_string(), | |
| ip_address: explored_endpoint.address.to_string(), | |
| port: 443, | |
| r#type: Some(RmsNodeType::Powershelf.into()), | |
| ..Default::default() | |
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pulls in a couple of downstream changes to support the 0.0.5 client, including setting the Vault path for switches (which is actually going to only be a temporary thing, but we still need it for the interim), and passing through the IP and MAC address to node registration (which is also going to actually be something we eventually move away from, but still need it for the interim).
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes