Skip to content

fix(api): bump librms client to 0.0.5 w/ support for host mac and ip addresses#433

Open
chet wants to merge 1 commit intoNVIDIA:mainfrom
chet:rms_zero_pt_six_support
Open

fix(api): bump librms client to 0.0.5 w/ support for host mac and ip addresses#433
chet wants to merge 1 commit intoNVIDIA:mainfrom
chet:rms_zero_pt_six_support

Conversation

@chet
Copy link
Contributor

@chet chet commented Mar 3, 2026

Description

This pulls in a couple of downstream changes to support the 0.0.5 client, including setting the Vault path for switches (which is actually going to only be a temporary thing, but we still need it for the interim), and passing through the IP and MAC address to node registration (which is also going to actually be something we eventually move away from, but still need it for the interim).

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@chet chet requested a review from a team as a code owner March 3, 2026 21:46
@chet chet force-pushed the rms_zero_pt_six_support branch from d2c9480 to 2e32b89 Compare March 3, 2026 21:49
…addresses

This pulls in a couple of downstream changes to support the 0.0.5 client, including setting the Vault path for switches (which is actually going to only be a temporary thing, but we still need it for the interim), and passing through the IP and MAC address to node registration (which is also going to actually be something we eventually move away from, but still need it for the interim).
@chet chet force-pushed the rms_zero_pt_six_support branch from 2e32b89 to 3920c98 Compare March 4, 2026 18:56
Comment on lines +775 to +787
let new_node_info = NewNodeInfo {
rack_id: rack_id.to_string(),
node_id: power_shelf_id.to_string(),
mac_address: expected_shelf.bmc_mac_address.to_string(),
ip_address: explored_endpoint.address.to_string(),
port: 443,
username: None,
password: None,
r#type: Some(RmsNodeType::Powershelf.into()),
vault_path: String::new(),
host_ip_addresses: vec![],
host_mac_addresses: vec![],
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you can use Default::default() here (not that it really matters)

Suggested change
let new_node_info = NewNodeInfo {
rack_id: rack_id.to_string(),
node_id: power_shelf_id.to_string(),
mac_address: expected_shelf.bmc_mac_address.to_string(),
ip_address: explored_endpoint.address.to_string(),
port: 443,
username: None,
password: None,
r#type: Some(RmsNodeType::Powershelf.into()),
vault_path: String::new(),
host_ip_addresses: vec![],
host_mac_addresses: vec![],
};
let new_node_info = NewNodeInfo {
rack_id: rack_id.to_string(),
node_id: power_shelf_id.to_string(),
mac_address: expected_shelf.bmc_mac_address.to_string(),
ip_address: explored_endpoint.address.to_string(),
port: 443,
r#type: Some(RmsNodeType::Powershelf.into()),
..Default::default()
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants