fix: use aws_lc_rs rustls CryptoProvider in workspace#436
Open
ianderson-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: use aws_lc_rs rustls CryptoProvider in workspace#436ianderson-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
aws_lc_rs rustls CryptoProvider in workspace#436ianderson-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Ian Anderson <ianderson@nvidia.com>
ianderson-nvidia
force-pushed
the
standardize_aws_lc_rs
branch
from
9304263 to
a4c6091
Compare
Contributor
|
my understanding is that the code is actually still using the same provider? its just the method in which we get that has changed? |
wminckler
approved these changes
Mar 4, 2026
kensimon
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
defaultfeature of therustlscrate uses theaws_lc_rscrate,aws_lc_rsis a ring-compatible crypto libraryhttps://docs.rs/rustls/latest/rustls/crypto/struct.CryptoProvider.html
Some crates were calling
crypto::ring::install_default()directly which were updated to useaws_lc_rsType of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
aws_lc_rsalso supports FIPS140-3 Cryptogrpahy