[nvq++] Removes MLIR's scf dialect
#2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use this dialect and its presence is a historical artifact. This change triggered the removal of two tests: * `test/Quake/ghz.qke` * `test/Quake/iqft.qke` Both tests are a reminder of a past when we had to write quantum kernels directly in MLIR because of a lack of frontend. Both no longer test aything useful. The commit modifies `test/Quake/canonical-2.qke`, which was only testing the canonicalization of `cc.scope` operations. The new form is removes the clutter, making the test more precise. `test/Translate/ghz.qke` had to be modified because it uses MLIR's `affined.for` and its conversion to LLVMDialect requires `scf.for`. Signed-off-by: boschmitt <7152025+boschmitt@users.noreply.github.com>
This was referenced Nov 28, 2024
schweitzpgi
approved these changes
Dec 9, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR chain
scfdialect #2435 <<<affinedialect #2436memrefdialect. #2438Description
We don't use this dialect and its presence is a historical artifact. This change triggered the removal of two tests:
test/Quake/ghz.qketest/Quake/iqft.qkeBoth tests are a reminder of a past when we had to write quantum kernels directly in MLIR because of a lack of frontend. Both no longer test aything useful.
The commit modifies
test/Quake/canonical-2.qke, which was only testing the canonicalization ofcc.scopeoperations. The new form is removes the clutter, making the test more precise.test/Translate/ghz.qkehad to be modified because it uses MLIR'saffined.forand its conversion to LLVMDialect requiresscf.for.Note: I'm unsure what
test/Translate/ghz.qkeis actually testing, I rewrote the test usingcc.loop, but might have just deleted as well. (@schweitzpgi You eyes on this would be greatly appreciated, the diff here is mostly variable names)