-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a yapf style config file. #2477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we put this into CUDA-QX. Hopefully it is equivalent to what you have here?
Yes. The file being added is the output from the tool itself for the "google" style. I guess the verbose format is intended to make sure any changes to default settings in future releases of yapf don't cause all the source code to get reformatted? That's a "known" issue when using clang-format, for example. At any rate, it's the same "google" style settings. |
I suspect we should consider updating .github/workflows/repo_checks.yml, too, because it is calling |
This makes the default "google" style and will help prevent people from accidentally using the yapf default style. Fix NVIDIA#2428 Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
up to chance/whatever your copy of yapf defaults them as. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
3a1477d
to
082a089
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This makes the default "google" style and will help prevent people from accidentally using the yapf default style.
Fix #2428
Description