Rename do something fixture by Ahmedadel87 · Pull Request #4087 · NVIDIA/cuda-quantum

Ahmedadel87 · 2026-03-04T13:21:42Z

Renamed the session-scoped fixture do_something to set_up_target in all relevant Python test files to improve the clarity. Testing showed no issues with the rename.

copy-pr-bot · 2026-03-04T13:21:46Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Omar <ahmedadel4355@gmail.com>

.gitignore

khalatepradnya

@Ahmedadel87 : Thank you for the contribution!
I think this can be further improved by giving meaningful names in all cases.

python/tests/interop/test_interop.py

.gitignore

… further clarity Signed-off-by: Omar <ahmedadel4355@gmail.com>

Signed-off-by: Omar <ahmedadel4355@gmail.com>

khalatepradnya

The second set of changes are looking good.
Please remove the unnecessary files and changes.

pytest_output.txt

python/tests/dynamics/integrators/system_models.py

…o rest_run_clear Signed-off-by: Omar <ahmedadel4355@gmail.com>

Signed-off-by: Omar <ahmedadel4355@gmail.com>

Ahmedadel87 · 2026-03-05T18:24:04Z

Made sure there are no changes except the renaming of do_something functions in the python/tests folders.

khalatepradnya · 2026-03-05T19:14:08Z

@Ahmedadel87 - Please sign your commits. See this.

Ahmedadel87 · 2026-03-05T22:14:43Z

@Ahmedadel87 - Please sign your commits. See this.

I have all signed except the first commit, but I don't know how I can change that commit now.

khalatepradnya · 2026-03-05T22:34:33Z

@Ahmedadel87 : Was this PR closed by mistake?

Ahmedadel87 · 2026-03-05T22:45:11Z

@Ahmedadel87 : Was this PR closed by mistake?

I don't know, I don't think I closed it.

Ahmedadel87 · 2026-03-05T22:48:06Z

@Ahmedadel87 : Was this PR closed by mistake?

It seems I have closed it by accident, I apologise for my mistake.

…nstead of n, and renamed one function for further clarity Signed-off-by: Omar <ahmedadel4355@gmail.com>

…ed one function. Signed-off-by: Omar <ahmedadel4355@gmail.com>

I, Omar <ahmedadel4355@gmail.com>, hereby add my Signed-off-by to this commit: 41b1527 Signed-off-by: Omar <ahmedadel4355@gmail.com>

github-actions · 2026-03-07T01:15:46Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Ahmedadel87 · 2026-03-07T09:49:33Z

Thanks, @Ahmedadel87! LGTM.

You are welcome, it was nice working with you!

khalatepradnya · 2026-03-12T18:15:14Z

Thanks, @Ahmedadel87! LGTM.

You are welcome, it was nice working with you!

@Ahmedadel87 - Can you align with the latest mainline (resolve conflicts), and do another sweep for do_something? I think newly added test files also should be updated, for example, python/tests/backends/test_tii.py (here).
Thanks!

Ahmedadel87 · 2026-03-14T16:29:53Z

Thanks, @Ahmedadel87! LGTM.

You are welcome, it was nice working with you!

@Ahmedadel87 - Can you align with the latest mainline (resolve conflicts), and do another sweep for do_something? I think newly added test files also should be updated, for example, python/tests/backends/test_tii.py (here). Thanks!

Sorry, bit late, but sure I can do that.

Signed-off-by: Omar <ahmedadel4355@gmail.com>

Signed-off-by: Omar <79374829+Ahmedadel87@users.noreply.github.com>

python/tests/backends/test_Pasqal.py

Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>

schweitzpgi · 2026-03-19T16:50:25Z

/ok to test 91a0df9

Command Bot: Processing...

schweitzpgi · 2026-03-19T16:52:42Z

@Ahmedadel87 please fix any failing CI jobs so we can merge these. Thanks for your contribution.

github-actions · 2026-03-19T18:19:01Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Ignore virtual environment folder

41b1527

Ahmedadel87 mentioned this pull request Mar 4, 2026

[Refactor] [python] [testing] Rename vague backend test fixtures (e.g. do_something) to descriptive names #4082

Open

Renamed session-scoped fixture 'do_something' to set_up_target'

8785f84

Signed-off-by: Omar <ahmedadel4355@gmail.com>

Ahmedadel87 force-pushed the rename-do-something-fixture branch from ca22189 to 8785f84 Compare March 4, 2026 14:40

sacpis reviewed Mar 4, 2026

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

khalatepradnya reviewed Mar 4, 2026

View reviewed changes

python/tests/interop/test_interop.py Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

khalatepradnya linked an issue Mar 4, 2026 that may be closed by this pull request

[Refactor] [python] [testing] Rename vague backend test fixtures (e.g. do_something) to descriptive names #4082

Open

Ahmedadel87 added 2 commits March 5, 2026 14:23

Removed venv and renamed certain functions to match their purpose for…

0e684de

… further clarity Signed-off-by: Omar <ahmedadel4355@gmail.com>

Fixed accidental change

4146553

Signed-off-by: Omar <ahmedadel4355@gmail.com>

khalatepradnya reviewed Mar 5, 2026

View reviewed changes

pytest_output.txt Outdated Show resolved Hide resolved

python/tests/dynamics/integrators/system_models.py Show resolved Hide resolved

Removed accidently added file and renamed rest_target_run_and_clear t…

0941165

…o rest_run_clear Signed-off-by: Omar <ahmedadel4355@gmail.com>

Ahmedadel87 force-pushed the rename-do-something-fixture branch from a0bf6c4 to 2a0c42e Compare March 5, 2026 18:14

Reverted accidental changes in '.gitignore'

57592bc

Signed-off-by: Omar <ahmedadel4355@gmail.com>

Ahmedadel87 force-pushed the rename-do-something-fixture branch from 2a0c42e to 57592bc Compare March 5, 2026 18:18

Merge branch 'main' into rename-do-something-fixture

4f81b6f

Ahmedadel87 closed this Mar 5, 2026

github-actions bot pushed a commit that referenced this pull request Mar 5, 2026

Cleaning up docs preview for PR #4087.

918ab17

khalatepradnya reopened this Mar 5, 2026

Ahmedadel87 added 2 commits March 6, 2026 13:29

Fixed /dynamics/integrators/system_models.py by making it end in rn i…

c5832be

…nstead of n, and renamed one function for further clarity Signed-off-by: Omar <ahmedadel4355@gmail.com>

Made sure dynamics/integrators/system_models.py ends in rn, and renam…

2bb3460

…ed one function. Signed-off-by: Omar <ahmedadel4355@gmail.com>

Ahmedadel87 force-pushed the rename-do-something-fixture branch from ba0e20e to 2bb3460 Compare March 6, 2026 10:49

DCO Remediation Commit for Omar <ahmedadel4355@gmail.com>

1b8d753

I, Omar <ahmedadel4355@gmail.com>, hereby add my Signed-off-by to this commit: 41b1527 Signed-off-by: Omar <ahmedadel4355@gmail.com>

Ahmedadel87 force-pushed the rename-do-something-fixture branch from 1941091 to 1b8d753 Compare March 6, 2026 11:19

Merge branch 'main' into rename-do-something-fixture

0c741ef

schweitzpgi added maintenance Work items to update and improve the code base testing Relates to testing python Pull requests that update python code labels Mar 9, 2026

Ahmedadel87 and others added 2 commits March 14, 2026 19:48

Renamed all do_something() functions in python/tests/backends.

4044184

Signed-off-by: Omar <ahmedadel4355@gmail.com>

Merge branch 'main' into rename-do-something-fixture

95f3593

Signed-off-by: Omar <79374829+Ahmedadel87@users.noreply.github.com>

khalatepradnya reviewed Mar 16, 2026

View reviewed changes

python/tests/backends/test_Pasqal.py Show resolved Hide resolved

Merge branch 'main' into rename-do-something-fixture

52440f7

schweitzpgi reviewed Mar 19, 2026

View reviewed changes

python/tests/backends/test_Pasqal.py Show resolved Hide resolved

Apply suggestion from @schweitzpgi

91a0df9

Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>

copy-pr-bot bot temporarily deployed to ghcr-ci March 19, 2026 16:50 Inactive

Conversation

Ahmedadel87 commented Mar 4, 2026 • edited by khalatepradnya Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot bot commented Mar 4, 2026

Uh oh!

Uh oh!

khalatepradnya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

khalatepradnya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Ahmedadel87 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khalatepradnya commented Mar 5, 2026

Uh oh!

Ahmedadel87 commented Mar 5, 2026

Uh oh!

khalatepradnya commented Mar 5, 2026

Uh oh!

Ahmedadel87 commented Mar 5, 2026

Uh oh!

Ahmedadel87 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 7, 2026

Uh oh!

Ahmedadel87 commented Mar 7, 2026

Uh oh!

khalatepradnya commented Mar 12, 2026

Uh oh!

Ahmedadel87 commented Mar 14, 2026

Uh oh!

Uh oh!

Uh oh!

schweitzpgi commented Mar 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schweitzpgi commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ahmedadel87 commented Mar 4, 2026 •

edited by khalatepradnya

Loading

Ahmedadel87 commented Mar 5, 2026 •

edited

Loading

Ahmedadel87 commented Mar 5, 2026 •

edited

Loading

schweitzpgi commented Mar 19, 2026 •

edited by github-actions bot

Loading