Skip to content

[Testing] - Fix test coverage#4140

Open
mitchdz wants to merge 7 commits intomainfrom
fix-test-coverage
Open

[Testing] - Fix test coverage#4140
mitchdz wants to merge 7 commits intomainfrom
fix-test-coverage

Conversation

@mitchdz
Copy link
Collaborator

@mitchdz mitchdz commented Mar 11, 2026

Fix codecov workflow

Codecov has been silently failing, thus creating no reports. This PR fixes that so now PRs will have a comment indicating the code coverage percentage.

Example message from codecov: #4140 (comment)

Signed-off-by: Mitchell <mitch_dz@hotmail.com>
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1 similar comment
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Mitchell <mitch_dz@hotmail.com>
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Mitchell <mitch_dz@hotmail.com>
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@60128ac). Learn more about missing BASE report.
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4140   +/-   ##
=======================================
  Coverage        ?   78.13%           
=======================================
  Files           ?      507           
  Lines           ?    66348           
  Branches        ?        0           
=======================================
  Hits            ?    51840           
  Misses          ?    14508           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Mitchell <mitch_dz@hotmail.com>
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

# mock servers (e.g., IQM, Scaleway). Pinned here so that all CI workflows
# and coverage scripts reference a single source of truth.
iqm-client==28.0.0
qio~=0.1.33
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update.
Q: How do we distinguish between what goes here, v/s what goes in https://github.com/NVIDIA/cuda-quantum/blob/main/requirements-dev.txt?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description is a good guide for that. Generally this new file can be used for backend testing and tooling. It doesn't make sense to ship iqm-client in our image as an example, so it falls in this file which is necessary for testing, but not for actually running the code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I follow... wouldn't you need these packages to run against the real hardware of that provider?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to by default ship all of these dependencies?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. Tagging @efratshabtai for guidance.

Signed-off-by: Mitchell <mitch_dz@hotmail.com>
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Mitchell <mitch_dz@hotmail.com>
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants