Skip to content

Adding test with docker #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mario21ic wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding test with docker #51

mario21ic wants to merge 2 commits into from

Conversation

@mario21ic
Copy link

@mario21ic mario21ic commented Apr 24, 2019

Add scripts to run inside a docker container

@drossetti drossetti requested a review from pakmarkthub June 18, 2019 17:54
@drossetti
Copy link
Member

drossetti commented Jun 18, 2019

@pakmarkthub can you please have a look?
@mario21ic

  • I suggest to simply remove 'sudo' from the existing insmod.sh file
  • I'd rather add docker specific files in a new specific subdir

@drossetti drossetti mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pakmarkthub pakmarkthub Awaiting requested review from pakmarkthub

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mario21ic @drossetti