Properly handle graceful shutdown of the kubelet plugin #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Oct 29, 2024
cmd/nvidia-dra-plugin/main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| sigc := make(chan os.Signal, 1) |
There was a problem hiding this comment.
Not specific to this PR, but I think in the controller component we use sigs here? I suppose sigc is Sig(nal) C(hannel)? Do we want to update for consistency?
There was a problem hiding this comment.
We normally use sigc. I missed this in reviewing @ArangoGutierrez 's PR for the controller. We should do a follow-up to make it consistent over there.
There was a problem hiding this comment.
I went back and looked and it seems we actually do use sigs everywhere -- not sure why I thought it was sigc. Updated.
elezar
reviewed
Oct 29, 2024
Signed-off-by: Kevin Klues <kklues@nvidia.com>
klueska
force-pushed
the
graceful-shutdown
branch
from
0801f73 to
9e00150
Compare
elezar
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.