Update all demo scripts for use on GKE with a k8s 1.31 alpha cluster #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klueska
force-pushed
the
update-gke-demo
branch
from
aac1e9b to
53420fa
Compare
andrewsykim
reviewed
Nov 6, 2024
demo/clusters/gke/create-cluster.sh
Outdated
| @@ -35,6 +35,7 @@ DRIVER_NAME=$(from_versions_mk "DRIVER_NAME") | |||
|
|
|||
| NETWORK_NAME="${DRIVER_NAME}-net" | |||
| CLUSTER_NAME="${DRIVER_NAME}-cluster" | |||
| NODE_VERSION="1.31.1-gke.2105000" | |||
There was a problem hiding this comment.
I would recommend we don't specify the full version 1.31.1-gke.2105000", as 2105000 will not be available forever. Instead just specifying v1.31.1 will default to the latest 1.31 GKE version
|
/cc @bobbypage |
Signed-off-by: Kevin Klues <kklues@nvidia.com>
klueska
force-pushed
the
update-gke-demo
branch
from
53420fa to
51040c4
Compare
|
thanks for updating this @klueska -- I plan to give it a test shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.