Allow OpenRM drivers to be discovered in CSV mode #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Tegra-based systems with OpenRM (e.g. Thor-based systems). We need to also discover driver libraries in the same way was what we do on regular desktop systems. This change ensures that these driver libraries and meta devices are discovered. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Pull Request Test Coverage Report for Build 17975570314Details
💛 - Coveralls |
| // GetCommonEdits generates a CDI specification that can be used for ANY devices | ||
| func (l *csvlib) GetCommonEdits() (*cdi.ContainerEdits, error) { | ||
| return edits.FromDiscoverer(discover.None{}) | ||
| if l.featureFlags["disable-openrm-drivers-in-csv"] { |
There was a problem hiding this comment.
Question: Where is this FeatureFlag documented?
There was a problem hiding this comment.
It isn't yet. This is something that I need to follow-up on if this PR moves out of draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Tegra-based systems with OpenRM (e.g. Thor-based systems). We need to also discover driver libraries in the same way was what we do on regular desktop systems. This change ensures that these driver libraries and meta devices are discovered.