Feature servingnode #458
Open
Feature servingnode #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 8, 2020 22:41
the tracked lock warning messages in the log for unconfigured parameters used the wrong config variable names. Fix that.
confgen was using the VirtualIP address of the volume group as the private IP address used to reach proxyfs. that is incorrect and probably doesn't work in general (proxyfs is not going to bind to the virtual IP addresses, particularly if they are added after Proxyfs starts up). Added knowledge of `ServingNode` and `PreferredPeer` to confgen. `ServingNode` overrides `PrimaryPeer` if both are present. If neither is present then confgen verifies that `PreferredPeer` is present (can be empty string) or flags an error in the config. In the future, the first time a new volume group is loaded with `monitorctl new-config ...` ServingNode will not be present (its set by `monitord`) and PrimaryPeer will not be present (its deprecated), but `PreferredPeer` should be present in this case. Add code to confgen to require that `PublicIPAddr` and `PublicInterface` is present in the config for each peer (node) that is serving a VolumeGroup as a sanity check. Fix confgen unit tests to assert that fetchVolumeInfo() did not return an error (previously unchecked), Tweak the sample configuration file used by the confgen unit tests to exercise some of the ServingNode/PrimaryPeer/PreferredPeer code, and also deleted `PrimaryPeer` from Volume entries. Add a little logging to proxyfs Format() operation to log the results of swiftclient.AccountGet().
Change ProxyFS, utilities, and unit tests to use "ServingNode" as
the node that serves a proxyfs file system instead of "PrimaryPeer".
The biggest part of the change is to add a function to the `transitions`
package, `GetServingNode()` that parses a ConfMap and returns the value
for ServingNode (if defined), PrimaryPeer (if defined), or an error.
An empty value results in an empty string (""), which is fine, and
is different than no OptionName at all.
This actually saves a number of lines of code.
Change most of the unit tests to say "SevingNode" instead of "PrimaryPeer"
for the "VolumeGroup" entry and delete the "PrimaryPeer" entry for
Volumes.
Add a unit test for `GetServingNode()` which tries the several
possibilities, including ServingNode and PrimaryPeer are both set,
but to different values (ServingNode wins).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from "PrimaryPeer" to "ServingNode" for volume groups to determine which node serves it.
Fix a bug in
confgenfor VirtualIP address for a volume group and add knowledge of the ServingNode to confgen.confenalso requires thatPublicIPAddrandPublicInterfacebe defined for any volume group that is exported.