Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parallelism and cardinality #1088

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maikel
Copy link
Collaborator

@maikel maikel commented Sep 24, 2023

This PR introduces 2 queries for sequence senders, which are useful for optimizations within algorithms.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 24, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler
Copy link
Collaborator

/ok to test

@maikel
Copy link
Collaborator Author

maikel commented Sep 25, 2023

I think parallelism and cardinality should not be forwarded queries. But join_env works only with forwarding. Is that an unnecessary requirement of join_env ?

@ericniebler
Copy link
Collaborator

I think parallelism and cardinality should not be forwarded queries. But join_env works only with forwarding. Is that an unnecessary requirement of join_env ?

Possibly. The use I had in mind for join_env is when a sender adaptor is augmenting its child sender's environment, in which case the exclusion of non-forwarding queries is correct.

But if you are just cobbling together a sender's environment from bits and bobs, none of which are from a child sender, then the current behavior is not what you want. In that case, perhaps we want a variant of join_env that doesn't exclude non-forwarding queries.

@maikel
Copy link
Collaborator Author

maikel commented Oct 10, 2023

Thats a very fair argument. I will provide a helper for what I really need

@ericniebler
Copy link
Collaborator

I think parallelism and cardinality should not be forwarded queries. But join_env works only with forwarding. Is that an unnecessary requirement of join_env?

@maikel stdexec now has the stdexec::env<> template for joining environments without any special handling for forwarding queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants