Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is for enumeration tool.
The testing program is enumeration.cpp.
In examples folder, I tested with command
make, andcse142 job run --lab test './enumeration.exe --param1-name par1 --param1 1 2 --param2-name par2 --param2 3 4 --param3-name par3 --param3 5 6 --engine papi --stat PAPI_L2_DCA --stat PAPI_TOT_CYC --stat PAPI_TOT_INS'. The output seems to be correct.I am worried that my code is not generic enough. I previously added some code to make sure cnn.exe works properly. Let me know if there is anything to be fixed!
By the way, should the base branch be devel or tng-devel? I believe we have tng-devel in latest version.