Open
Conversation
jspjutNV
approved these changes
Apr 17, 2023
Contributor
jspjutNV
left a comment
jspjutNV
left a comment
There was a problem hiding this comment.
These changes look reasonable and it passes all tests.
jspjutNV
suggested changes
Apr 17, 2023
Contributor
There was a problem hiding this comment.
Sorry, I was just testing #348 and I'm now getting crashes unrelated to #348 from this branch. It's probably not ready to merge yet.
When I select a different experiment from the dropdown, the user appears to not correctly switch and I get an error like the following:
User "anon" has session with ID: "240Hz" in their User Status "sessions" Array. This session ID does not appear in the experiment config file's "sessions" array. Valid options are:
Expression: false
C:\g3d\G3D10\G3D-app.lib\source\GApp.cpp:856
As another update, it appears that my crash was just a result of how #348 clobbers the userstatus.Any and causes the previously working experiment to break repeatedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch attempts to fix some remaining bugs that occur when running in the
Debugconfiguration withdeveloperMode = true. Specifically exceptions were being thrown around removing elements that were not present in the widget manager. This was an issue before and after callingclear()on the widget manager was removed.This branch also resets the
m_firstSessionflag, avoiding issues w/ undesired state when switching experiments. It should be thoroughly tested for behavior changes and possible remaining exceptions before being merged as the case it impacts is relatively niche, but it could break behavior inReleaseif not carefully implemented.