Merge pull request #2535 from xt0rted/code-analysis

Setup code analysis
NancyFx · Nov 1, 2016 · 10318e6 · 10318e6
2 parents 877fa86 + c930b8c
commit 10318e6
Show file tree

Hide file tree

Showing 58 changed files with 648 additions and 72 deletions.
diff --git a/Nancy.ruleset b/Nancy.ruleset
diff --git a/src/Nancy.Authentication.Basic.MSBuild/Nancy.Authentication.Basic.csproj b/src/Nancy.Authentication.Basic.MSBuild/Nancy.Authentication.Basic.csproj
@@ -36,7 +36,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\Nancy.Authentication.Basic.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
@@ -124,6 +124,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Authentication.Basic.MSBuild/packages.config b/src/Nancy.Authentication.Basic.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Authentication.Basic/project.json b/src/Nancy.Authentication.Basic/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "A basic HTTP authentication provider for Nancy.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -15,7 +15,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.Authentication.Forms.MSBuild/Nancy.Authentication.Forms.csproj b/src/Nancy.Authentication.Forms.MSBuild/Nancy.Authentication.Forms.csproj
@@ -36,7 +36,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\Nancy.Authentication.Forms.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
@@ -121,6 +121,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Authentication.Forms.MSBuild/packages.config b/src/Nancy.Authentication.Forms.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Authentication.Forms/project.json b/src/Nancy.Authentication.Forms/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "A forms authentication provider for Nancy.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -15,7 +15,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.Authentication.Stateless.MSBuild/Nancy.Authentication.Stateless.csproj b/src/Nancy.Authentication.Stateless.MSBuild/Nancy.Authentication.Stateless.csproj
@@ -36,7 +36,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\Nancy.Authentication.Stateless.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
@@ -108,6 +108,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Authentication.Stateless.MSBuild/packages.config b/src/Nancy.Authentication.Stateless.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Authentication.Stateless/project.json b/src/Nancy.Authentication.Stateless/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "A stateless authentication provider for Nancy.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -15,7 +15,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.Embedded.MSBuild/Nancy.Embedded.csproj b/src/Nancy.Embedded.MSBuild/Nancy.Embedded.csproj
@@ -22,6 +22,7 @@
     <WarningLevel>4</WarningLevel>
     <DocumentationFile>bin\Debug\Nancy.Embedded.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -55,6 +56,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Embedded.MSBuild/packages.config b/src/Nancy.Embedded.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Embedded/project.json b/src/Nancy.Embedded/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "Helpers for serving embedded static content with Nancy.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -15,7 +15,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.Encryption.MachineKey.MSBuild/Nancy.Encryption.MachineKey.csproj b/src/Nancy.Encryption.MachineKey.MSBuild/Nancy.Encryption.MachineKey.csproj
@@ -22,6 +22,7 @@
     <WarningLevel>4</WarningLevel>
     <DocumentationFile>bin\Debug\Nancy.Encryption.MachineKey.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -85,6 +86,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Encryption.MachineKey.MSBuild/packages.config b/src/Nancy.Encryption.MachineKey.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Encryption.MachineKey/project.json b/src/Nancy.Encryption.MachineKey/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "System.Web MachineKey encrypton and HMAC providers for Nancy.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -15,7 +15,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.Hosting.Aspnet.MSBuild/Nancy.Hosting.Aspnet.csproj b/src/Nancy.Hosting.Aspnet.MSBuild/Nancy.Hosting.Aspnet.csproj
@@ -36,7 +36,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\Nancy.Hosting.Aspnet.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
@@ -135,6 +135,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Hosting.Aspnet.MSBuild/packages.config b/src/Nancy.Hosting.Aspnet.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Hosting.Aspnet/project.json b/src/Nancy.Hosting.Aspnet/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "Enables hosting Nancy on ASP.NET.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -15,7 +15,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.Hosting.Self.MSBuild/Nancy.Hosting.Self.csproj b/src/Nancy.Hosting.Self.MSBuild/Nancy.Hosting.Self.csproj
@@ -36,7 +36,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\Nancy.Hosting.Self.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
@@ -138,6 +138,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Hosting.Self.MSBuild/packages.config b/src/Nancy.Hosting.Self.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Hosting.Self/project.json b/src/Nancy.Hosting.Self/project.json
@@ -1,4 +1,4 @@
-{
+{
     "version": "2.0.0-barneyrubble",
     "description": "Enables hosting Nancy in any application.",
     "authors": [ "Andreas Håkansson, Steven Robbins and contributors" ],
@@ -16,7 +16,8 @@
     },
 
     "dependencies": {
-        "Nancy": { "target": "project" }
+      "AsyncUsageAnalyzers": "1.0.0-alpha003",
+      "Nancy": { "target": "project" }
     },
 
     "frameworks": {

diff --git a/src/Nancy.MSBuild/Nancy.csproj b/src/Nancy.MSBuild/Nancy.csproj
@@ -34,9 +34,10 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\Nancy.XML</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
+    <RunCodeAnalysis>true</RunCodeAnalysis>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -356,15 +357,15 @@
     <Compile Include="..\Nancy\Helpers\ExceptionExtensions.cs">
       <Link>Helpers\ExceptionExtensions.cs</Link>
     </Compile>
-    <Compile Include="..\Nancy\HttpLink.cs">
-      <Link>HttpLink.cs</Link>
-    </Compile>
-    <Compile Include="..\Nancy\HttpLinkBuilder.cs">
-      <Link>HttpLinkBuilder.cs</Link>
-    </Compile>
-    <Compile Include="..\Nancy\HttpLinkRelation.cs">
-      <Link>HttpLinkRelation.cs</Link>
-    </Compile>
+    <Compile Include="..\Nancy\HttpLink.cs">
+      <Link>HttpLink.cs</Link>
+    </Compile>
+    <Compile Include="..\Nancy\HttpLinkBuilder.cs">
+      <Link>HttpLinkBuilder.cs</Link>
+    </Compile>
+    <Compile Include="..\Nancy\HttpLinkRelation.cs">
+      <Link>HttpLinkRelation.cs</Link>
+    </Compile>
     <Compile Include="..\Nancy\IAssemblyCatalog.cs">
       <Link>IAssemblyCatalog.cs</Link>
     </Compile>
@@ -1534,6 +1535,12 @@
       <Link>Diagnostics\Views\login.sshtml</Link>
     </EmbeddedResource>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it.
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.MSBuild/packages.config b/src/Nancy.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>
diff --git a/src/Nancy.Metadata.Modules.MSBuild/Nancy.Metadata.Modules.csproj b/src/Nancy.Metadata.Modules.MSBuild/Nancy.Metadata.Modules.csproj
@@ -23,6 +23,7 @@
     <WarningLevel>4</WarningLevel>
     <DocumentationFile>bin\Debug\Nancy.Metadata.Modules.xml</DocumentationFile>
     <Prefer32Bit>false</Prefer32Bit>
+    <CodeAnalysisRuleSet>..\..\Nancy.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -96,6 +97,12 @@
       <Name>Nancy</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="..\..\packages\AsyncUsageAnalyzers.1.0.0-alpha003\analyzers\dotnet\AsyncUsageAnalyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

diff --git a/src/Nancy.Metadata.Modules.MSBuild/packages.config b/src/Nancy.Metadata.Modules.MSBuild/packages.config
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="AsyncUsageAnalyzers" version="1.0.0-alpha003" targetFramework="net45" developmentDependency="true" />
+</packages>