Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiclass confusion matrix #287

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

cartgr
Copy link
Contributor

@cartgr cartgr commented Apr 27, 2023

  • Multiclass confusion matrix calculation
  • Multiclass confusion matrix estimation
  • Docs for both
  • Tests for both

@cartgr cartgr requested review from nnansters and nikml as code owners April 27, 2023 02:11
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (dd20ef7) 83.40% compared to head (413970c) 83.57%.

❗ Current head 413970c differs from pull request most recent head 88050cc. Consider uploading reports for the commit 88050cc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   83.40%   83.57%   +0.16%     
==========================================
  Files         100      100              
  Lines        7245     7435     +190     
  Branches     1275     1321      +46     
==========================================
+ Hits         6043     6214     +171     
- Misses        905      916      +11     
- Partials      297      305       +8     
Files Coverage Δ
...annyml/sampling_error/multiclass_classification.py 100.00% <100.00%> (ø)
nannyml/thresholds.py 85.71% <ø> (ø)
...performance_estimation/confidence_based/metrics.py 95.23% <90.52%> (-0.60%) ⬇️
...e_calculation/metrics/multiclass_classification.py 80.39% <84.37%> (+1.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stale
Copy link

stale bot commented Aug 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 26, 2023
@stale stale bot closed this Sep 2, 2023
@nnansters nnansters removed the stale label Sep 3, 2023
@nnansters nnansters reopened this Sep 3, 2023
Copy link

stale bot commented Nov 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 2, 2023
# Conflicts:
#	docs/tutorials/performance_estimation/multiclass_performance_estimation.rst
@nnansters
Copy link
Contributor

Finally wrapping this one up @cartgr . Thanks again for everything buddy 🥇

@stale stale bot removed the stale label Nov 9, 2023
@nnansters nnansters merged commit 47b457e into main Nov 9, 2023
nnansters added a commit that referenced this pull request Nov 9, 2023
* create tester

* Updated tester

* multiclass cm performance estimation

* Multiclass confusion matrix calc. and estimation + docs and tests for both

* Removed scratch testing files

* updating MCM docs

* Re-align docs with main version

* [skip ci] Update CHANGELOG.md

---------

Co-authored-by: Nikolaos Perrakis <nikos@nannyml.com>
Co-authored-by: Niels Nuyttens <niels@nannyml.com>
nnansters added a commit that referenced this pull request Nov 9, 2023
* fix specificity calculation for CBPE

* Feature/multiclass confusion matrix (#287)

* create tester

* Updated tester

* multiclass cm performance estimation

* Multiclass confusion matrix calc. and estimation + docs and tests for both

* Removed scratch testing files

* updating MCM docs

* Re-align docs with main version

* [skip ci] Update CHANGELOG.md

---------

Co-authored-by: Nikolaos Perrakis <nikos@nannyml.com>
Co-authored-by: Niels Nuyttens <niels@nannyml.com>

* Small refactor to checks in realized performance calculations to make them consistent with the dedicated realized performance calculator.

* Fix  broken tests

* Fix linting errors due to merges

---------

Co-authored-by: Carter Blair <carterblair@uvic.ca>
Co-authored-by: Niels Nuyttens <niels@nannyml.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants