Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize calculation for L-Infinity method #342

Merged
merged 3 commits into from
Nov 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix mypy error
  • Loading branch information
michael-nml committed Nov 20, 2023
commit fb270dfcf8d0ef0b9528bfc83b510917e688bfac
2 changes: 1 addition & 1 deletion nannyml/drift/univariate/methods.py
Original file line number Diff line number Diff line change
@@ -503,7 +503,7 @@ def __init__(self, **kwargs) -> None:
An optional lower threshold for the performance metric.
"""

self._reference_proba: Optional[dict] = None
self._reference_proba: Optional[pd.Series] = None

def _fit(self, reference_data: pd.Series, timestamps: Optional[pd.Series] = None) -> Self:
reference_data = _remove_nans(reference_data)