Remove chi2 thresholds for analysis & reference #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chi2 thresholding is based on p-values, which means the calculated thresholds are irrelevant. Previously thresholds were removed as part of alerting. As this is only applied on analysis data the threshold value was still available on reference data, which led to confusion. This commit changes that so the chi2 threshold values are removed across the entire dataset.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 83.01% 83.04% +0.03%
==========================================
Files 100 100
Lines 7546 7549 +3
Branches 1351 1351
==========================================
+ Hits 6264 6269 +5
Misses 956 956
+ Partials 326 324 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chi2 thresholding is based on p-values, which means the calculated thresholds are irrelevant. Previously thresholds were removed as part of alerting. As this is only applied on analysis data the threshold value was still available on reference data, which led to confusion.
This commit changes that so the chi2 threshold values are removed across the entire dataset.