Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix limiting CBPE confidence bands to 0 #360

Closed
wants to merge 1 commit into from
Closed

Fix limiting CBPE confidence bands to 0 #360

wants to merge 1 commit into from

Conversation

michael-nml
Copy link
Collaborator

This PR fixes limiting the CBPE confidence bands when the limit is set to 0. The logic previously worked incorrectly if a limit of 0 was configured.

@nikml
Copy link
Contributor

nikml commented Feb 8, 2024

Let's not merge this please.
Fix should be like this.
2b4655a

Also my PR is removing confidence_upper_bounds as they are redundant. I 'll update CBPE there

@nikml
Copy link
Contributor

nikml commented Feb 8, 2024

closing if that' ok

@nikml nikml closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnansters nnansters Awaiting requested review from nnansters nnansters is a code owner

@nikml nikml Awaiting requested review from nikml nikml is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-nml @nikml