Fix duplicate X-values in KDE distribution #362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue for KDE distribution calculation returning duplicate X-values. This is an edge case of the
statsmodel.nonparametric.KDEUnivariate
function.Reproduction example:
Output:
nr duplicate X-values: 505
Normally input data containing a single value would result in an exception, but in this case it does not due to some form of precision error.
Running the above example with different input data yields:
data = np.array([-0.100865, -0.100865, -0.100865, -0.100865, -0.100865], dtype='float16')
=> errordata = np.array([-0.100865, -0.100865, -0.100865, -0.100865, -0.100865], dtype='float32')
=> errordata = np.array([-0.100865, -0.100865, -0.100865, -0.100865, -0.100865], dtype='float64')
=> same output as example above