Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated matplotlib and seaborn versions #389

Merged
merged 1 commit into from
May 16, 2024

Conversation

nnansters
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.53%. Comparing base (8ced18c) to head (5493766).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files         110      110           
  Lines        9221     9221           
  Branches     1650     1650           
=======================================
  Hits         7057     7057           
  Misses       1699     1699           
  Partials      465      465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters marked this pull request as ready for review May 16, 2024 10:23
@nnansters nnansters requested a review from nikml as a code owner May 16, 2024 10:23
@nnansters nnansters merged commit 9a1760f into main May 16, 2024
7 of 8 checks passed
@tacaswell
Copy link

I do not understand why you are pinning Matplotlib this way. Given that the Matplotlib pinning is Python version dependent I suspect that this does not mean your are dependent on a feature in newer versions of Matplotlib. The branch name suggest that something was broken, but I am having trouble guessing what.

@nnansters
Copy link
Contributor Author

Hey @tacaswell ,

We did run into an sudden issue breaking our build.

import seaborn as sns
.tox/py39/lib/python3.9/site-packages/seaborn/init.py:9: in
from .matrix import * # noqa: F401,F403
.tox/py39/lib/python3.9/site-packages/seaborn/matrix.py:12: in
from . import cm
.tox/py39/lib/python3.9/site-packages/seaborn/cm.py:1582: in
mpl_cm.register_cmap(_name, _cmap)
E AttributeError: module 'matplotlib.cm' has no attribute 'register_cmap'

Since those dependencies were already kind of ancient we bumped them, taking support for Python 3.7 into account as well as Seaborn support.

To be honest: not sure if this was the best way to do it, but it occurred at a very inconvenient time. Any suggestions on how we could have done this cleaner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants