Skip to content

Conversation

@ppinchuk
Copy link
Collaborator

Long time coming

@ppinchuk ppinchuk added this to the Finishing touches for OSS milestone Oct 21, 2025
@ppinchuk ppinchuk self-assigned this Oct 21, 2025
@ppinchuk ppinchuk requested a review from castelao as a code owner October 21, 2025 18:54
@ppinchuk ppinchuk added chore Maintenance work that does not impact the user github_actions Pull requests that update GitHub Actions code labels Oct 21, 2025
@ppinchuk ppinchuk requested a review from Copilot October 21, 2025 18:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Python test infrastructure using Tox for testing across multiple Python versions (3.12, 3.13, 3.14) and updates test fixtures, dependencies, and CI workflows accordingly.

Key Changes:

  • Introduces Tox configuration for multi-version Python testing
  • Updates test fixtures from test_data_dir to test_data_files_dir
  • Consolidates Python checks (linting and testing) into a single CI workflow

Reviewed Changes

Copilot reviewed 13 out of 61 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tox.ini Adds Tox configuration for testing across Python 3.12-3.14 with specific dependency versions
.github/workflows/ci-python.yml New consolidated workflow for linting, unit tests, integration tests, and Tox-based tests
.github/workflows/lint-python.yml Removed (consolidated into ci-python.yml)
tests/python/conftest.py Adds test_data_files_dir fixture to complement existing test_data_dir
tests/python/validation/*.py Updates test fixtures to use test_data_files_dir
tests/python/test_integrated.py Updates error handling and search engine import
pyproject.toml Updates pytest configuration and adds explicit dependency constraints
pixi.lock Downgrades several dependencies to ensure compatibility
compass/data/conus_jurisdictions.csv Adds descriptive names to Maryland district subdivisions
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ppinchuk ppinchuk mentioned this pull request Oct 21, 2025
@ppinchuk ppinchuk requested a review from Copilot October 22, 2025 00:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 61 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ppinchuk
Copy link
Collaborator Author

@castelao this is ready for review

castelao
castelao previously approved these changes Oct 22, 2025
Copy link
Member

@castelao castelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks Paul! I have just a few minor comments.

@ppinchuk
Copy link
Collaborator Author

@castelao This is ready for re-review

castelao
castelao previously approved these changes Oct 23, 2025
@ppinchuk ppinchuk merged commit d02b9d8 into main Oct 24, 2025
12 checks passed
@ppinchuk ppinchuk deleted the pp/tox branch October 24, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance work that does not impact the user github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants