-
Notifications
You must be signed in to change notification settings - Fork 3
Add unit tests for parsing module #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to top-level description
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
castelao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this tests. I didn't check the logic of most of the values themselves, but everything make sense.
It might be worth merging #342 first, so this PR here can validate the setup used there.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 36.08% 36.50% +0.42%
==========================================
Files 45 45
Lines 4240 4240
Branches 380 380
==========================================
+ Hits 1530 1548 +18
+ Misses 2687 2670 -17
+ Partials 23 22 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Overview
This PR adds comprehensive test coverage for COMPASS parsing utilities and updates the CI workflow to trigger on test file changes.
test_sync_retrytotest_llm_response_as_json)Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
clean_backticks_from_llm_response,extract_ord_year_from_doc_attrs,num_ordinances_in_doc,num_ordinances_dataframe,ordinances_bool_index, andload_configfunctions. Also corrects the test function name fromtest_sync_retrytotest_llm_response_as_json.tests/**path, ensuring CI runs when test files are modified