Skip to content

Add progress bar unit tests #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ppinchuk merged 9 commits into from
Nov 17, 2025
Merged

Add progress bar unit tests #335

ppinchuk merged 9 commits into from
Nov 17, 2025

Conversation

@ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Nov 9, 2025 •
edited
Loading

Pull Request Overview

This pull request adds comprehensive unit tests for the compass.pb module, which handles progress bar functionality in the COMPASS CLI.

  • Adds 501 lines of test coverage for progress bar helpers
  • Tests core functionality including main tasks, jurisdiction bars, file downloads, and website crawling progress bars
  • Includes async tests for context managers and proper cleanup verification

@ppinchuk ppinchuk requested a review from castelao as a code owner November 9, 2025 02:29
Copilot AI review requested due to automatic review settings November 9, 2025 02:29
@ppinchuk ppinchuk self-assigned this Nov 9, 2025
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python labels Nov 9, 2025
@ppinchuk ppinchuk added this to the Finishing touches for OSS milestone Nov 9, 2025
Copilot AI reviewed Nov 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment •
edited by ppinchuk
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to main description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

castelao
castelao approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@castelao castelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still didn't get used to COMPASS' progress bar. It is so cool!

@ppinchuk ppinchuk merged commit 782ae70 into main Nov 17, 2025
12 checks passed
@ppinchuk ppinchuk deleted the pp/pb_tests branch November 17, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@castelao castelao castelao approved these changes

Assignees

@ppinchuk ppinchuk

Labels

enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python

Projects

None yet

Milestone

Finishing touches for OSS

Development

Successfully merging this pull request may close these issues.

2 participants

@ppinchuk @castelao