Coil API

src/EnergyPlus/AirflowNetwork/src/Solver.cpp

@@ -1532,7 +1532,7 @@ namespace AirflowNetwork {
                 DisSysCompHXData(i).EPlusType = hx_type;             // coil type
                 DisSysCompHXData(i).L = L;                           // Air path length
                 DisSysCompHXData(i).hydraulicDiameter = D;           // Air path hydraulic diameter
-                DisSysCompHXData(i).CoilParentExists = HVACHXAssistedCoolingCoil::VerifyHeatExchangerParent(m_state, hx_type, hx_name);
+                DisSysCompHXData(i).CoilParentExists = HXAssistCoil::VerifyHeatExchangerParent(m_state, hx_type, hx_name);
 
                 // Add the element to the lookup table, check for name overlaps
                 if (elements.find(DisSysCompHXData(i).name) == elements.end()) {
@@ -1642,7 +1642,7 @@ namespace AirflowNetwork {
         // Using/Aliasing
         using Curve::GetCurveIndex;
         using DataLoopNode::ObjectIsParent;
-        using HVACHXAssistedCoolingCoil::VerifyHeatExchangerParent;
+        using HXAssistCoil::VerifyHeatExchangerParent;
         using MixedAir::GetOAMixerNumber;
         using NodeInputManager::GetOnlySingleNode;
         using OutAirNodeManager::SetOutAirNodes;
@@ -10342,7 +10342,6 @@ namespace AirflowNetwork {
         using namespace DataLoopNode;
         auto &NumPrimaryAirSys = m_state.dataHVACGlobal->NumPrimaryAirSys;
         using DXCoils::SetDXCoilAirLoopNumber;
-        using HeatingCoils::SetHeatingCoilAirLoopNumber;
         using HVACStandAloneERV::GetStandAloneERVNodeNumber;
         using HVACVariableRefrigerantFlow::getVRFTUNodeNumber;
         using SplitterComponent::GetSplitterNodeNumbers;
@@ -10766,21 +10765,15 @@ namespace AirflowNetwork {
                         SetDXCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum);
                     }
 
-                } else if (SELECT_CASE_var == "COIL:HEATING:FUEL") {
-                    ValidateComponent(m_state, "Coil:Heating:Fuel", DisSysCompCoilData(i).name, IsNotOK, format(RoutineName) + CurrentModuleObject);
-                    if (IsNotOK) {
+                } else if (SELECT_CASE_var == "COIL:HEATING:FUEL" ||
+                           SELECT_CASE_var == "COIL:HEATING:ELECTRIC" ||
+                           SELECT_CASE_var == "COIL:HEATING:ELECTRIC:MULTISTAGE" ||
+                           SELECT_CASE_var == "COIL:HEATING:GAS:MULTISTAGE") {
+                    int coilNum = HeatingCoils::GetCoilIndex(m_state, DisSysCompCoilData(i).name);
+                    if (coilNum == 0) {
                         ErrorsFound = true;
                     } else {
-                        SetHeatingCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum, ErrorsFound);
-                    }
-
-                } else if (SELECT_CASE_var == "COIL:HEATING:ELECTRIC") {
-                    ValidateComponent(
-                        m_state, "Coil:Heating:Electric", DisSysCompCoilData(i).name, IsNotOK, format(RoutineName) + CurrentModuleObject);
-                    if (IsNotOK) {
-                        ErrorsFound = true;
-                    } else {
-                        SetHeatingCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum, ErrorsFound);
+                        HeatingCoils::SetCoilAirLoopNumber(m_state, coilNum, DisSysCompCoilData(i).AirLoopNum);
                     }
 
                 } else if (SELECT_CASE_var == "COIL:COOLING:WATER") {
@@ -10844,7 +10837,8 @@ namespace AirflowNetwork {
                     if (IsNotOK) {
                         ErrorsFound = true;
                     } else {
-                        SetVarSpeedDXCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum);
+                        int coilNum = VariableSpeedCoils::GetCoilIndex(m_state, DisSysCompCoilData(i).name);
+                        SetVarSpeedDXCoilAirLoopNumber(m_state, coilNum, DisSysCompCoilData(i).AirLoopNum);
                     }
 
                 } else if (SELECT_CASE_var == "COIL:HEATING:DX:VARIABLESPEED") {
@@ -10854,7 +10848,8 @@ namespace AirflowNetwork {
                     if (IsNotOK) {
                         ErrorsFound = true;
                     } else {
-                        SetVarSpeedDXCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum);
+                        int const coilNum = VariableSpeedCoils::GetCoilIndex(m_state, DisSysCompCoilData(i).name);
+                        SetVarSpeedDXCoilAirLoopNumber(m_state, coilNum, DisSysCompCoilData(i).AirLoopNum);
                     }
                 } else if (SELECT_CASE_var == "COIL:COOLING:WATERTOAIRHEATPUMP:EQUATIONFIT") {
                     ValidateComponent(m_state,
@@ -10910,22 +10905,6 @@ namespace AirflowNetwork {
                     } else {
                         SetDXCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum);
                     }
-                } else if (SELECT_CASE_var == "COIL:HEATING:ELECTRIC:MULTISTAGE") {
-                    ValidateComponent(
-                        m_state, "Coil:Heating:Electric:MultiStage", DisSysCompCoilData(i).name, IsNotOK, format(RoutineName) + CurrentModuleObject);
-                    if (IsNotOK) {
-                        ErrorsFound = true;
-                    } else {
-                        SetHeatingCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum, ErrorsFound);
-                    }
-                } else if (SELECT_CASE_var == "COIL:HEATING:GAS:MULTISTAGE") {
-                    ValidateComponent(
-                        m_state, "Coil:Heating:Gas:MultiStage", DisSysCompCoilData(i).name, IsNotOK, format(RoutineName) + CurrentModuleObject);
-                    if (IsNotOK) {
-                        ErrorsFound = true;
-                    } else {
-                        SetHeatingCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum, ErrorsFound);
-                    }
                 } else {
                     ShowSevereError(m_state, format(RoutineName) + CurrentModuleObject + " Invalid coil type = " + DisSysCompCoilData(i).name);
                     ErrorsFound = true;

src/EnergyPlus/Autosizing/All_Simple_Sizing.cc

@@ -314,10 +314,8 @@ Real64 HeatingCoilDesAirInletTempSizer::size(EnergyPlusData &state, Real64 _orig
         }
     }
     this->selectSizerOutput(state, errorsFound);
-    if (this->isCoilReportObject) {
-        state.dataRptCoilSelection->coilSelectionReportObj->setCoilEntAirTemp(
-            state, this->compName, this->compType, this->autoSizedValue, this->curSysNum, this->curZoneEqNum);
-    }
+    if (this->isCoilReportObject) 
+        ReportCoilSelection::setCoilEntAirTemp(state, this->coilReportNum, this->autoSizedValue, this->curSysNum, this->curZoneEqNum);
     return this->autoSizedValue;
 }
 
@@ -348,9 +346,8 @@ Real64 HeatingCoilDesAirOutletTempSizer::size(EnergyPlusData &state, Real64 _ori
         }
     }
     this->selectSizerOutput(state, errorsFound);
-    if (this->isCoilReportObject) {
-        state.dataRptCoilSelection->coilSelectionReportObj->setCoilLvgAirTemp(state, this->compName, this->compType, this->autoSizedValue);
-    }
+    if (this->isCoilReportObject)
+        ReportCoilSelection::setCoilLvgAirTemp(state, this->coilReportNum, this->autoSizedValue);
     return this->autoSizedValue;
 }
 
@@ -385,9 +382,8 @@ Real64 HeatingCoilDesAirInletHumRatSizer::size(EnergyPlusData &state, Real64 _or
         }
     }
     this->selectSizerOutput(state, errorsFound);
-    if (this->isCoilReportObject) {
-        state.dataRptCoilSelection->coilSelectionReportObj->setCoilEntAirHumRat(state, this->compName, this->compType, this->autoSizedValue);
-    }
+    if (this->isCoilReportObject)
+        ReportCoilSelection::setCoilEntAirHumRat(state, this->coilReportNum, this->autoSizedValue);
     return this->autoSizedValue;
 }
 

src/EnergyPlus/Autosizing/Base.cc

@@ -67,6 +67,8 @@ void BaseSizer::initializeWithinEP(EnergyPlusData &state,
 {
     this->initialized = true;
     this->compType = _compType;
+    // This is done during the isValidCoilType call.  Why?
+    // this->coilType = static_cast<HVAC::CoilType>(getEnumValue(HVAC::coilTypeNamesUC, Util::makeUPPER(_compType)));
     this->compName = _compName;
     this->isEpJSON = state.dataGlobal->isEpJSON;
     this->printWarningFlag = _printWarningFlag;
@@ -108,6 +110,7 @@ void BaseSizer::initializeWithinEP(EnergyPlusData &state,
     this->airloopDOAS = state.dataAirLoopHVACDOAS->airloopDOAS;
     if (EnergyPlus::BaseSizer::isValidCoilType(this->compType)) { // coil reports fail if compType is not one of HVAC::cAllCoilTypes
         this->isCoilReportObject = true;
+        this->coilReportNum = ReportCoilSelection::getReportIndex(state, this->compName, this->coilType);
     }
     if (EnergyPlus::BaseSizer::isValidFanType(this->compType)) { // fan reports fail if compType is not a valid fan type
         this->isFanReportObject = true;
@@ -607,16 +610,8 @@ void BaseSizer::select2StgDXHumCtrlSizerOutput(EnergyPlusData &state, bool &erro
 
 bool BaseSizer::isValidCoilType(std::string const &_compType)
 {
-    int coilNum = 0;
-    for (auto const &coilType : HVAC::cAllCoilTypes) {
-        coilNum += 1;
-        if (Util::SameString(_compType, coilType)) {
-            this->coilType_Num = coilNum;
-            return true;
-        }
-    }
-    this->coilType_Num = 0;
-    return false;
+    this->coilType = static_cast<HVAC::CoilType>(getEnumValue(HVAC::coilTypeNamesUC, Util::makeUPPER(_compType)));
+    return this->coilType != HVAC::CoilType::Invalid;
 }
 
 bool BaseSizer::isValidFanType(std::string const &_compType)
@@ -939,7 +934,7 @@ void BaseSizer::clearState()
     sizingDesValueFromParent = false;
     airLoopSysFlag = false;
     oaSysFlag = false;
-    coilType_Num = 0;
+    coilType = HVAC::CoilType::Invalid;
     compType = "";
     compName = "";
     isEpJSON = false;

src/EnergyPlus/Autosizing/Base.hh

@@ -123,6 +123,7 @@ struct BaseSizer
     bool dataScalableSizingON = false;
     bool dataScalableCapSizingON = false;
     bool isCoilReportObject = false; // provides access to coil reporting
+    int coilReportNum = -1; // Coil report index
     bool isFanReportObject = false;  // provides access to fan reporting
     bool initialized = false;        // indicates initializeWithinEP was called
     AutoSizingResultType errorType = AutoSizingResultType::NoError;
@@ -139,11 +140,12 @@ struct BaseSizer
     bool sizingDesValueFromParent = false;
     bool airLoopSysFlag = false;
     bool oaSysFlag = false;
-    int coilType_Num = 0;
+    HVAC::CoilType coilType = HVAC::CoilType::Invalid;
     std::string compType;
     std::string compName;
     bool isEpJSON = false;
 
+
     bool sysSizingRunDone = false;
     bool zoneSizingRunDone = false;
     int curSysNum = 0;

src/EnergyPlus/Autosizing/BaseSizerWithScalableInputs.cc

@@ -101,10 +101,9 @@ void BaseSizerWithScalableInputs::initializeWithinEP(EnergyPlusData &state,
 
         // This should work for both fan types
         if (this->primaryAirSystem(this->curSysNum).supFanNum > 0) {
-            state.dataRptCoilSelection->coilSelectionReportObj->setCoilSupplyFanInfo(
+            ReportCoilSelection::setCoilSupplyFanInfo(
                 state,
-                this->compName,
-                this->compType,
+                this->coilReportNum,
                 state.dataFans->fans(this->primaryAirSystem(this->curSysNum).supFanNum)->Name,
                 state.dataFans->fans(this->primaryAirSystem(this->curSysNum).supFanNum)->type,
                 this->primaryAirSystem(this->curSysNum).supFanNum);

src/EnergyPlus/Autosizing/BaseSizerWithScalableInputs.hh

@@ -86,7 +86,7 @@ struct BaseSizerWithScalableInputs : BaseSizerWithFanHeatInputs
     Real64 suppHeatCap = 0.0;
     Real64 unitaryHeatCap = 0.0;
     int dataTotCapCurveIndex = 0;
-    int dataCoolCoilType = -1;
+    HVAC::CoilType dataCoolCoilType = HVAC::CoilType::Invalid; // Why the 'data' prefix?
     int dataCoolCoilIndex = -1;
 
     int zoneHVACSizingIndex = 0;
@@ -125,7 +125,7 @@ struct BaseSizerWithScalableInputs : BaseSizerWithFanHeatInputs
         suppHeatCap = 0.0;
         unitaryHeatCap = 0.0;
         zoneHVACSizingIndex = 0;
-        dataCoolCoilType = -1;
+        dataCoolCoilType = HVAC::CoilType::Invalid;
         dataCoolCoilIndex = -1;
         zoneHVACSizing.clear();
     }

src/EnergyPlus/Autosizing/CoolingAirFlowSizing.cc

@@ -336,10 +336,9 @@ Real64 CoolingAirFlowSizer::size(EnergyPlusData &state, Real64 _originalValue, b
         if (this->overrideSizeString) {
             if (Util::SameString(this->compType, "ZoneHVAC:FourPipeFanCoil")) {
                 this->sizingString = "Maximum Supply Air Flow Rate [m3/s]";
-                if (this->isEpJSON) {
+                if (this->isEpJSON) 
                     this->sizingString = "maximum_supply_air_flow_rate [m3/s]";
-                }
-            } else if (this->coilType_Num == HVAC::CoilDX_CoolingTwoSpeed) {
+            } else if (this->coilType == HVAC::CoilType::CoolingDXTwoSpeed) {
                 if (this->dataDXSpeedNum == 1) { // mode 1 is high speed in DXCoils loop
                     if (this->isEpJSON) {
                         this->sizingString = "high_speed_rated_air_flow_rate [m3/s]";
@@ -357,18 +356,18 @@ Real64 CoolingAirFlowSizer::size(EnergyPlusData &state, Real64 _originalValue, b
                 this->sizingString = "cooling_supply_air_flow_rate [m3/s]";
             }
         }
-        if (this->dataScalableSizingON) {
-            if (this->zoneAirFlowSizMethod == DataSizing::SupplyAirFlowRate || this->zoneAirFlowSizMethod == DataSizing::None) {
-                this->sizingStringScalable = "(scaled by flow / zone) ";
-            } else if (this->zoneAirFlowSizMethod == DataSizing::FlowPerFloorArea) {
-                this->sizingStringScalable = "(scaled by flow / area) ";
-            } else if (this->zoneAirFlowSizMethod == DataSizing::FractionOfAutosizedCoolingAirflow ||
-                       this->zoneAirFlowSizMethod == DataSizing::FractionOfAutosizedHeatingAirflow) {
-                this->sizingStringScalable = "(scaled by fractional multiplier) ";
-            } else if (this->zoneAirFlowSizMethod == DataSizing::FlowPerCoolingCapacity ||
-                       this->zoneAirFlowSizMethod == DataSizing::FlowPerHeatingCapacity) {
-                this->sizingStringScalable = "(scaled by flow / capacity) ";
-            }
+    }
+    if (this->dataScalableSizingON) {
+        if (this->zoneAirFlowSizMethod == DataSizing::SupplyAirFlowRate || this->zoneAirFlowSizMethod == DataSizing::None) {
+            this->sizingStringScalable = "(scaled by flow / zone) ";
+        } else if (this->zoneAirFlowSizMethod == DataSizing::FlowPerFloorArea) {
+            this->sizingStringScalable = "(scaled by flow / area) ";
+        } else if (this->zoneAirFlowSizMethod == DataSizing::FractionOfAutosizedCoolingAirflow ||
+                   this->zoneAirFlowSizMethod == DataSizing::FractionOfAutosizedHeatingAirflow) {
+            this->sizingStringScalable = "(scaled by fractional multiplier) ";
+        } else if (this->zoneAirFlowSizMethod == DataSizing::FlowPerCoolingCapacity ||
+                   this->zoneAirFlowSizMethod == DataSizing::FlowPerHeatingCapacity) {
+            this->sizingStringScalable = "(scaled by flow / capacity) ";
         }
     }
     if (this->dataDXCoolsLowSpeedsAutozize) {
@@ -378,8 +377,7 @@ Real64 CoolingAirFlowSizer::size(EnergyPlusData &state, Real64 _originalValue, b
 
     if (this->isCoilReportObject) {
         // SizingResult is airflow in m3/s
-        state.dataRptCoilSelection->coilSelectionReportObj->setCoilAirFlow(
-            state, this->compName, this->compType, this->autoSizedValue, this->wasAutoSized);
+      ReportCoilSelection::setCoilAirFlow(state, this->coilReportNum, this->autoSizedValue, this->wasAutoSized);
     }
     if (this->isFanReportObject) {
         //  fill fan peak day and time here
@@ -396,8 +394,7 @@ Real64 CoolingAirFlowSizer::size(EnergyPlusData &state, Real64 _originalValue, b
                     dateTimeFanPeak = format("{}/{} {}",
                                              state.dataWeather->DesDayInput(this->finalZoneSizing(this->curZoneEqNum).CoolDDNum).Month,
                                              state.dataWeather->DesDayInput(this->finalZoneSizing(this->curZoneEqNum).CoolDDNum).DayOfMonth,
-                                             state.dataRptCoilSelection->coilSelectionReportObj->getTimeText(
-                                                 state, this->finalZoneSizing(this->curZoneEqNum).TimeStepNumAtCoolMax));
+                                             ReportCoilSelection::getTimeText(state, this->finalZoneSizing(this->curZoneEqNum).TimeStepNumAtCoolMax));
                 }
             } else if (heatingFlow) {
                 if (this->finalZoneSizing(this->curZoneEqNum).HeatDDNum > 0 &&
@@ -406,8 +403,7 @@ Real64 CoolingAirFlowSizer::size(EnergyPlusData &state, Real64 _originalValue, b
                     dateTimeFanPeak = format("{}/{} {}",
                                              state.dataWeather->DesDayInput(this->finalZoneSizing(this->curZoneEqNum).HeatDDNum).Month,
                                              state.dataWeather->DesDayInput(this->finalZoneSizing(this->curZoneEqNum).HeatDDNum).DayOfMonth,
-                                             state.dataRptCoilSelection->coilSelectionReportObj->getTimeText(
-                                                 state, this->finalZoneSizing(this->curZoneEqNum).TimeStepNumAtHeatMax));
+                                             ReportCoilSelection::getTimeText(state, this->finalZoneSizing(this->curZoneEqNum).TimeStepNumAtHeatMax));
                 }
             }
         }