Clarify DefrostEIRTempModFac is an EIR, not an EIR modifier#11425
Merged
Clarify DefrostEIRTempModFac is an EIR, not an EIR modifier#11425
Conversation
Fixes #11380 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@JanghyunJK, @rraustad thoughts on this change? |
brianlball
added
the
Documentation
mitchute
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11380
Clarify in the Engineering Reference that DefrostEIRTempModFac represents a defrost energy input ratio (defrost power
/ rated capacity), not a modifier applied to a rated EIR. Other EIR modifier curves (e.g. EIRTempModFac) multiply
against rated EIR, but the defrost curve multiplies against rated capacity directly. The terminology was inconsistent
and confusing. Four locations updated in coils.tex:
No code changes — documentation only.