Skip to content

Fix DesignSpecification:ZoneHVAC:Sizing check for FractionOfAutosizedHeatingCapacity to not point to cooling capacity field #11427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchute merged 2 commits into from
Feb 24, 2026
+0 −70
Merged

Fix DesignSpecification:ZoneHVAC:Sizing check for FractionOfAutosizedHeatingCapacity to not point to cooling capacity field #11427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b55a9e
Change ScaledCoolingCapacity to ScaledHeatingCapacity in SizingManage…
joseph-robertson Feb 20, 2026
1760694
Remove several error checks on DesignSpecification:ZoneHVAC:Sizing fi…
joseph-robertson Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 0 additions & 70 deletions src/EnergyPlus/SizingManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4981,14 +4981,6 @@ void GetZoneHVACSizing(EnergyPlusData &state)
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity == AutoSize) {
state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true;
}
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity < 0.0 &&
state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity != AutoSize) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(
state,
format("Illegal {} = {:.7T}", cNumericFields(iCoolDesignCapacityNumericNum), Numbers(iCoolDesignCapacityNumericNum)));
ErrorsFound = true;
}
} else {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum)));
Expand All @@ -4999,21 +4991,6 @@ void GetZoneHVACSizing(EnergyPlusData &state)
state.dataSize->ZoneHVACSizing(zSIndex).CoolingCapMethod = CapacityPerFloorArea;
if (!lNumericBlanks(iCoolCapacityPerFloorAreaNumericNum)) {
state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity = Numbers(iCoolCapacityPerFloorAreaNumericNum);
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity <= 0.0) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum)));
ShowContinueError(state,
format("Illegal {} = {:.7T}",
cNumericFields(iCoolCapacityPerFloorAreaNumericNum),
Numbers(iCoolCapacityPerFloorAreaNumericNum)));
ErrorsFound = true;
// Autosized input is not allowed
} else if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity == AutoSize) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum)));
ShowContinueError(state, format("Illegal {} = Autosize", cNumericFields(iCoolCapacityPerFloorAreaNumericNum)));
ErrorsFound = true;
}
} else {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum)));
Expand All @@ -5024,18 +5001,6 @@ void GetZoneHVACSizing(EnergyPlusData &state)
state.dataSize->ZoneHVACSizing(zSIndex).CoolingCapMethod = FractionOfAutosizedCoolingCapacity;
if (!lNumericBlanks(iCoolFracOfAutosizedCapacityNumericNum)) {
state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity = Numbers(iCoolFracOfAutosizedCapacityNumericNum);
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity == AutoSize) {
state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true;
}
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity < 0.0 &&
state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity != AutoSize) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state,
format("Illegal {} = {:.7T}",
cNumericFields(iCoolFracOfAutosizedCapacityNumericNum),
Numbers(iCoolFracOfAutosizedCapacityNumericNum)));
ErrorsFound = true;
}
} else {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum)));
Expand All @@ -5058,14 +5023,6 @@ void GetZoneHVACSizing(EnergyPlusData &state)
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity == AutoSize) {
state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true;
}
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity < 0.0 &&
state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity != AutoSize) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(
state,
format("Illegal {} = {:.7T}", cNumericFields(iHeatDesignCapacityNumericNum), Numbers(iHeatDesignCapacityNumericNum)));
ErrorsFound = true;
}
} else {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum)));
Expand All @@ -5076,21 +5033,6 @@ void GetZoneHVACSizing(EnergyPlusData &state)
state.dataSize->ZoneHVACSizing(zSIndex).HeatingCapMethod = CapacityPerFloorArea;
if (!lNumericBlanks(iHeatCapacityPerFloorAreaNumericNum)) {
state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity = Numbers(iHeatCapacityPerFloorAreaNumericNum);
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity <= 0.0) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum)));
ShowContinueError(state,
format("Illegal {} = {:.7T}",
cNumericFields(iHeatCapacityPerFloorAreaNumericNum),
Numbers(iHeatCapacityPerFloorAreaNumericNum)));
ErrorsFound = true;
// Autosized input is not allowed
} else if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity == AutoSize) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum)));
ShowContinueError(state, format("Illegal {} = Autosize", cNumericFields(iHeatCapacityPerFloorAreaNumericNum)));
ErrorsFound = true;
}
} else {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum)));
Expand All @@ -5101,18 +5043,6 @@ void GetZoneHVACSizing(EnergyPlusData &state)
state.dataSize->ZoneHVACSizing(zSIndex).HeatingCapMethod = FractionOfAutosizedHeatingCapacity;
if (!lNumericBlanks(iHeatFracOfAutosizedCapacityNumericNum)) {
state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity = Numbers(iHeatFracOfAutosizedCapacityNumericNum);
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity == AutoSize) {
state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true;
}
if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity < 0.0 &&
state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity != AutoSize) {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state,
format("Illegal {} = {:.7T}",
cNumericFields(iHeatFracOfAutosizedCapacityNumericNum),
Numbers(iHeatFracOfAutosizedCapacityNumericNum)));
ErrorsFound = true;
}
} else {
ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name));
ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum)));
Expand Down