Skip to content

Protect Annual Table Bin Limits When No Data Are Present#11430

Merged
mitchute merged 1 commit intodevelopfrom
fix-output-table-annual-bin-limits
Feb 23, 2026
Merged

Protect Annual Table Bin Limits When No Data Are Present#11430
mitchute merged 1 commit intodevelopfrom
fix-output-table-annual-bin-limits

Conversation

@mitchute
Copy link
Collaborator

Pull request overview

#11422 unified the initialization values in annual output tables, but I merged it before realizing that the table bin limits need to be protected for cases when no data are present. minVal and maxVal are being used as sentinel values; however, when no data are present this results in an underflow error here.

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute requested a review from JasonGlazer February 23, 2026 19:04
@mitchute mitchute self-assigned this Feb 23, 2026
@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Feb 23, 2026
Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes do look correct.

@mitchute
Copy link
Collaborator Author

Thanks @rraustad. Tests are clean again, so I'm going to go ahead and merge this.

@mitchute mitchute merged commit f358d75 into develop Feb 23, 2026
12 checks passed
@mitchute mitchute deleted the fix-output-table-annual-bin-limits branch February 23, 2026 22:39
@JasonGlazer
Copy link
Contributor

This looks good to me, too (although I'm not a big fan of the C++ ternary operator)

@mitchute
Copy link
Collaborator Author

Thanks @JasonGlazer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants