Skip to content

Comments

WindowManager Array Transition (part 1) #11432

Open
amirroth wants to merge 9 commits intodevelopfrom
WindowManager2
Open

WindowManager Array Transition (part 1) #11432
amirroth wants to merge 9 commits intodevelopfrom
WindowManager2

Conversation

@amirroth
Copy link
Collaborator

Pull request overview

This is a refactor that moves some arrays in WindowManager from Array1D<> and Array2D<> to std::array<> and std::array<std::array<>> and moves some variables from state to local scope.

@amirroth amirroth self-assigned this Feb 25, 2026
@amirroth amirroth added Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Feb 25, 2026
@amirroth amirroth added this to the EnergyPlus 26.1 milestone Feb 25, 2026
@github-actions
Copy link

⚠️ Regressions detected on ubuntu-24.04 for commit c7dc965

Regression Summary
  • EIO: 3
  • ESO Small Diffs: 1
  • MTR Small Diffs: 1
  • Table Small Diffs: 1
  • ESO Big Diffs: 2
  • Table Big Diffs: 2

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit c7dc965

Regression Summary
  • EIO: 3
  • ESO Small Diffs: 1
  • MTR Small Diffs: 1
  • Table Small Diffs: 1
  • ESO Big Diffs: 2
  • Table Big Diffs: 2

@github-actions
Copy link

⚠️ Regressions detected on ubuntu-24.04 for commit 1f95993

Regression Summary
  • EIO: 3
  • ESO Small Diffs: 1
  • MTR Small Diffs: 1
  • Table Small Diffs: 1
  • ESO Big Diffs: 2
  • Table Big Diffs: 2

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit 1f95993

Regression Summary
  • EIO: 3
  • ESO Small Diffs: 1
  • MTR Small Diffs: 1
  • Table Small Diffs: 1
  • ESO Big Diffs: 2
  • Table Big Diffs: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NotIDDChange Code does not impact IDD (can be merged after IO freeze) Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants