Skip to content

Correct excess air flow in AirLoopHVAC:UnitaryHeatCool using Coil:Cooling:DX:VariableSpeed cooling coil #11435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rraustad wants to merge 2 commits into
base: develop
Choose a base branch
from
+17 −15
Open

Correct excess air flow in AirLoopHVAC:UnitaryHeatCool using Coil:Cooling:DX:VariableSpeed cooling coil #11435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5455eb0
Limit VSHP air flow to parent maximum air flow
rraustad Feb 26, 2026
6a3959b
Merge branch 'develop' of https://github.com/NatLabRockies/EnergyPlus…
rraustad Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/EnergyPlus/Furnaces.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10951,8 +10951,9 @@ namespace Furnaces {
if (thisFurnace.NumOfSpeedCooling > 0) {
state.dataFurnaces->CompOnMassFlow = thisFurnace.CoolMassFlowRate(thisFurnace.NumOfSpeedCooling);
state.dataFurnaces->CompOnFlowRatio = thisFurnace.MSCoolingSpeedRatio(thisFurnace.NumOfSpeedCooling);
state.dataHVACGlobal->MSHPMassFlowRateLow = thisFurnace.CoolMassFlowRate(thisFurnace.NumOfSpeedCooling);
state.dataHVACGlobal->MSHPMassFlowRateHigh = thisFurnace.CoolMassFlowRate(thisFurnace.NumOfSpeedCooling);
state.dataFurnaces->CompOnMassFlow = min(state.dataFurnaces->CompOnMassFlow, thisFurnace.MaxCoolAirMassFlow);
state.dataHVACGlobal->MSHPMassFlowRateLow = state.dataFurnaces->CompOnMassFlow;
state.dataHVACGlobal->MSHPMassFlowRateHigh = state.dataFurnaces->CompOnMassFlow;
} else {
state.dataFurnaces->CompOnMassFlow = thisFurnace.MaxCoolAirMassFlow;
state.dataFurnaces->CompOnFlowRatio = thisFurnace.CoolingSpeedRatio;
Expand All @@ -10968,8 +10969,9 @@ namespace Furnaces {
if (thisFurnace.NumOfSpeedHeating > 0) {
state.dataFurnaces->CompOnMassFlow = thisFurnace.HeatMassFlowRate(thisFurnace.NumOfSpeedHeating);
state.dataFurnaces->CompOnFlowRatio = thisFurnace.MSHeatingSpeedRatio(thisFurnace.NumOfSpeedHeating);
state.dataHVACGlobal->MSHPMassFlowRateLow = thisFurnace.HeatMassFlowRate(thisFurnace.NumOfSpeedHeating);
state.dataHVACGlobal->MSHPMassFlowRateHigh = thisFurnace.HeatMassFlowRate(thisFurnace.NumOfSpeedHeating);
state.dataFurnaces->CompOnMassFlow = min(state.dataFurnaces->CompOnMassFlow, thisFurnace.MaxHeatAirMassFlow);
state.dataHVACGlobal->MSHPMassFlowRateLow = state.dataFurnaces->CompOnMassFlow;
state.dataHVACGlobal->MSHPMassFlowRateHigh = state.dataFurnaces->CompOnMassFlow;
} else {
state.dataFurnaces->CompOnMassFlow = thisFurnace.MaxHeatAirMassFlow;
state.dataFurnaces->CompOnFlowRatio = thisFurnace.HeatingSpeedRatio;
Expand Down
22 changes: 11 additions & 11 deletions tst/EnergyPlus/unit/Furnaces.unit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,21 +182,21 @@ TEST_F(EnergyPlusFixture, SetVSHPAirFlowTest_VSFurnaceFlowTest)
state->dataFurnaces->HeatingLoad = true;
state->dataFurnaces->CoolingLoad = false;
SetVSHPAirFlow(*state, FurnaceNum, PartLoadRatio, OnOffAirFlowRatio);
EXPECT_DOUBLE_EQ(1.0, state->dataHVACGlobal->MSHPMassFlowRateLow);
EXPECT_DOUBLE_EQ(1.0, state->dataHVACGlobal->MSHPMassFlowRateHigh);
EXPECT_DOUBLE_EQ(0.5, state->dataHVACGlobal->MSHPMassFlowRateLow);
EXPECT_DOUBLE_EQ(0.5, state->dataHVACGlobal->MSHPMassFlowRateHigh);
EXPECT_DOUBLE_EQ(0.0, state->dataFurnaces->CompOffMassFlow);
EXPECT_DOUBLE_EQ(1.0, state->dataFurnaces->CompOnMassFlow);
EXPECT_DOUBLE_EQ(0.5, state->dataFurnaces->CompOnMassFlow);
EXPECT_DOUBLE_EQ(1.0, OnOffAirFlowRatio);
EXPECT_DOUBLE_EQ(1.0, state->dataLoopNodes->Node(state->dataFurnaces->Furnace(FurnaceNum).FurnaceInletNodeNum).MassFlowRate);
EXPECT_DOUBLE_EQ(0.5, state->dataLoopNodes->Node(state->dataFurnaces->Furnace(FurnaceNum).FurnaceInletNodeNum).MassFlowRate);

// Test availability manager signal
state->dataHVACGlobal->TurnFansOff = true;
state->dataHVACGlobal->TurnFansOn = false;
SetVSHPAirFlow(*state, FurnaceNum, PartLoadRatio, OnOffAirFlowRatio);
EXPECT_DOUBLE_EQ(1.0, state->dataHVACGlobal->MSHPMassFlowRateLow);
EXPECT_DOUBLE_EQ(1.0, state->dataHVACGlobal->MSHPMassFlowRateHigh);
EXPECT_DOUBLE_EQ(0.5, state->dataHVACGlobal->MSHPMassFlowRateLow);
EXPECT_DOUBLE_EQ(0.5, state->dataHVACGlobal->MSHPMassFlowRateHigh);
EXPECT_DOUBLE_EQ(0.0, state->dataFurnaces->CompOffMassFlow);
EXPECT_DOUBLE_EQ(1.0, state->dataFurnaces->CompOnMassFlow);
EXPECT_DOUBLE_EQ(0.5, state->dataFurnaces->CompOnMassFlow);
EXPECT_DOUBLE_EQ(0.0, OnOffAirFlowRatio);
EXPECT_DOUBLE_EQ(0.0, state->dataLoopNodes->Node(state->dataFurnaces->Furnace(FurnaceNum).FurnaceInletNodeNum).MassFlowRate);
state->dataHVACGlobal->TurnFansOff = false;
Expand Down Expand Up @@ -230,12 +230,12 @@ TEST_F(EnergyPlusFixture, SetVSHPAirFlowTest_VSFurnaceFlowTest)
state->dataFurnaces->HeatingLoad = false;
state->dataFurnaces->CoolingLoad = true;
SetVSHPAirFlow(*state, FurnaceNum, PartLoadRatio, OnOffAirFlowRatio);
EXPECT_DOUBLE_EQ(1.2, state->dataHVACGlobal->MSHPMassFlowRateLow);
EXPECT_DOUBLE_EQ(1.2, state->dataHVACGlobal->MSHPMassFlowRateHigh);
EXPECT_DOUBLE_EQ(0.75, state->dataHVACGlobal->MSHPMassFlowRateLow);
EXPECT_DOUBLE_EQ(0.75, state->dataHVACGlobal->MSHPMassFlowRateHigh);
EXPECT_DOUBLE_EQ(0.0, state->dataFurnaces->CompOffMassFlow);
EXPECT_DOUBLE_EQ(1.2, state->dataFurnaces->CompOnMassFlow);
EXPECT_DOUBLE_EQ(0.75, state->dataFurnaces->CompOnMassFlow);
EXPECT_DOUBLE_EQ(1.0, OnOffAirFlowRatio);
EXPECT_DOUBLE_EQ(1.2, state->dataLoopNodes->Node(state->dataFurnaces->Furnace(FurnaceNum).FurnaceInletNodeNum).MassFlowRate);
EXPECT_DOUBLE_EQ(0.75, state->dataLoopNodes->Node(state->dataFurnaces->Furnace(FurnaceNum).FurnaceInletNodeNum).MassFlowRate);

// constant fan mode should drop to idle flow rate
state->dataFurnaces->Furnace(FurnaceNum).fanOp = HVAC::FanOp::Continuous;
Expand Down
Loading