Skip to content

Make all Linux apt-install Workflows Non-interactive#11437

Merged
mitchute merged 1 commit intodevelopfrom
non-interactive-linux-workflows
Feb 26, 2026
Merged

Make all Linux apt-install Workflows Non-interactive#11437
mitchute merged 1 commit intodevelopfrom
non-interactive-linux-workflows

Conversation

@mitchute
Copy link
Collaborator

Pull request overview

Linux workflows have been failing sporadically due to interactive prompts on apt-install commands. This explicitly makes all workflows non-interactive.

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute self-assigned this Feb 26, 2026
@mitchute mitchute added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Feb 26, 2026
@mitchute
Copy link
Collaborator Author

This workflow won't be tested until merged, but I'm not expecting any issues. Merging.

@mitchute mitchute merged commit 7c55972 into develop Feb 26, 2026
11 of 12 checks passed
@mitchute mitchute deleted the non-interactive-linux-workflows branch February 26, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotPublish Includes changes that shouldn't be reported in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants