Skip to content

Comments

Improved AirflowNetwork Flow Linkage Controls#8703

Open
jasondegraw wants to merge 1 commit intodevelopfrom
afn-linkage-control
Open

Improved AirflowNetwork Flow Linkage Controls#8703
jasondegraw wants to merge 1 commit intodevelopfrom
afn-linkage-control

Conversation

@jasondegraw
Copy link
Member

@jasondegraw jasondegraw commented Apr 8, 2021

Pull request overview

AirflowNetwork does not currently distinguish between a control factor and a multiplier for flow linkages. This PR makes that distinction for multizone and distribution linkages.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jasondegraw jasondegraw added the NewFeature Includes code to add a new feature to EnergyPlus label Apr 8, 2021
@nrel-bot-3
Copy link

nrel-bot-3 commented May 7, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

9 similar comments
@nrel-bot-3
Copy link

nrel-bot-3 commented Jun 4, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

nrel-bot-3 commented Jul 2, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

nrel-bot-3 commented Jul 30, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

nrel-bot-3 commented Aug 27, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

nrel-bot-3 commented Sep 24, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

nrel-bot-3 commented Oct 22, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Nov 19, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 17, 2021

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-3
Copy link

nrel-bot-3 commented Jan 14, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@mjwitte mjwitte added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Feb 8, 2022
@mjwitte mjwitte added this to the EnergyPlus 22.2 milestone Feb 10, 2022
@nrel-bot-2b
Copy link

nrel-bot-2b commented Mar 11, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

5 similar comments
@nrel-bot
Copy link

nrel-bot commented Apr 8, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented May 6, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Jun 3, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jul 1, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Jul 29, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

Myoldmopar commented Jul 29, 2022

@jasondegraw do you anticipate this progressing for I/O freeze? I'm just scanning PRs looking at milestones now while prepping for the review push over the next couple weeks. Thanks! (If I repeat this comment on any other PRs, my apologies for cross posting.)

@jasondegraw
Copy link
Member Author

jasondegraw commented Aug 3, 2022

@Myoldmopar No, I've made enough big changes to AFN for this release. I do intend to have this wrapped up before this release but not in time to make the release.

@nrel-bot
Copy link

nrel-bot commented Sep 21, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

5 similar comments
@nrel-bot-3
Copy link

nrel-bot-3 commented Oct 19, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 16, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2b
Copy link

nrel-bot-2b commented Dec 14, 2022

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2b
Copy link

nrel-bot-2b commented Jan 11, 2023

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Feb 8, 2023

@jasondegraw @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented May 13, 2025

@jasondegraw it has been 9 days since this pull request was last updated.

1 similar comment
@nrel-bot-2
Copy link

nrel-bot-2 commented May 21, 2025

@jasondegraw it has been 9 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented May 30, 2025

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jun 12, 2025

@jasondegraw it has been 14 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jun 25, 2025

@jasondegraw it has been 12 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jul 11, 2025

@jasondegraw it has been 16 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jul 21, 2025

@jasondegraw it has been 10 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Aug 2, 2025

@jasondegraw it has been 12 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 1, 2025

@jasondegraw it has been 60 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Oct 8, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

20 similar comments
@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 15, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Oct 22, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 29, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Nov 5, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 12, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 19, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Nov 26, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 3, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 10, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 17, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 24, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 31, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 7, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 14, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 21, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 27, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 4, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 11, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 18, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 25, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) NewFeature Includes code to add a new feature to EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasondegraw @nrel-bot-3 @nrel-bot @nrel-bot-2 @nrel-bot-2b @nrel-bot-2c @Myoldmopar @mjwitte