Skip to content

Comments

Add AFN network builder script#9516

Draft
jasondegraw wants to merge 2 commits intodevelopfrom
afn-network-builder
Draft

Add AFN network builder script#9516
jasondegraw wants to merge 2 commits intodevelopfrom
afn-network-builder

Conversation

@jasondegraw
Copy link
Member

@jasondegraw jasondegraw commented Jul 1, 2022

Pull request overview

Add a script to build out a basic AirflowNetwork model. Draft for now, need to add quite a lot more in terms of documentation and support.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jasondegraw
Create build_airflownetwork.py
c0f22eb
@jasondegraw
Fix bizarre git screwup
70d944f 
I won't force push but I thought about really hard
@nrel-bot
Copy link

nrel-bot commented Jul 29, 2022

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

1 similar comment
@nrel-bot-3
Copy link

nrel-bot-3 commented Aug 26, 2022

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@Myoldmopar Myoldmopar added this to the EnergyPlus 23.1 milestone Sep 22, 2022
@nrel-bot-2
Copy link

nrel-bot-2 commented Oct 20, 2022

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

4 similar comments
@nrel-bot-2c
Copy link

nrel-bot-2c commented Nov 17, 2022

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Dec 15, 2022

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 12, 2023

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot
Copy link

nrel-bot commented Feb 9, 2023

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

Myoldmopar commented Feb 23, 2023

@jasondegraw do you think this will be good for 23.1? Doesn't matter either way, just setting up the review queue and moving things to the right milestone.

@nrel-bot
Copy link

nrel-bot commented Mar 24, 2023

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

1 similar comment
@nrel-bot-2c
Copy link

nrel-bot-2c commented Apr 21, 2023

@jasondegraw @Myoldmopar it has been 28 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Apr 29, 2023

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented May 6, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

7 similar comments
@nrel-bot-2b
Copy link

nrel-bot-2b commented May 13, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented May 20, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented May 20, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2b
Copy link

nrel-bot-2b commented May 27, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jun 3, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jun 10, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2b
Copy link

nrel-bot-2b commented Jun 17, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jun 26, 2023

@jasondegraw it has been 9 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jul 3, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2b
Copy link

nrel-bot-2b commented Jul 10, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jul 28, 2023

@jasondegraw it has been 18 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Aug 4, 2023

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Aug 12, 2023

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jun 12, 2025

@jasondegraw it has been 14 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jun 25, 2025

@jasondegraw it has been 12 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jul 3, 2025

@jasondegraw it has been 8 days since this pull request was last updated.

1 similar comment
@nrel-bot-2
Copy link

nrel-bot-2 commented Jul 11, 2025

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jul 21, 2025

@jasondegraw it has been 10 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Aug 2, 2025

@jasondegraw it has been 12 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Aug 22, 2025

@jasondegraw it has been 20 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Sep 5, 2025

@jasondegraw it has been 14 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Sep 29, 2025

@jasondegraw it has been 24 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 6, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

2 similar comments
@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 13, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 20, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@mitchute mitchute removed this from the EnergyPlus 24.2 milestone Oct 22, 2025
@nrel-bot-2c
Copy link

nrel-bot-2c commented Oct 30, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

11 similar comments
@nrel-bot-2c
Copy link

nrel-bot-2c commented Nov 6, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 13, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 20, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Nov 27, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 4, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 11, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 18, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 25, 2025

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jan 1, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jan 8, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Jan 15, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 23, 2026

@jasondegraw it has been 8 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Jan 30, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

3 similar comments
@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 6, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 13, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Feb 20, 2026

@jasondegraw it has been 7 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasondegraw @nrel-bot @nrel-bot-3 @nrel-bot-2 @nrel-bot-2c @Myoldmopar @nrel-bot-2b @mitchute