Conversation
# Updating for newer fastkml versions `fastkml` was pinned. This is no longer needed and led to package issues surrounding `pkg_resources`, which older versions of `fastkml` used. This PR unpins and updates code to allow for the most recent version of `fastkml`. ## PR Checklist <!--Tick these boxes if they are complete, or format them as "[x]" for the markdown to render. --> - [x] `RELEASE.md` has been updated to describe the changes made in this PR - [ ] Documentation - [ ] Docstrings are up-to-date - [ ] Related `docs/` files are up-to-date, or added when necessary - [ ] Documentation has been rebuilt successfully - [ ] Examples have been updated - [ ] Tests pass (If not, and this is expected, please elaborate in the tests section) - [ ] PR description thoroughly describes the new feature, bug fix, etc. ## Related issues <!--If one exists, link to a related GitHub Issue.--> ## Impacted areas of the software <!-- Replace the below example with any added or modified files, and briefly describe what has been changed or added, and why. --> - `path/to/file.extension` - `method1`: What and why something was changed in one sentence or less. ## Additional supporting information <!--Add any other context about the problem here.--> ## Test results, if applicable <!-- Add the results from unit tests and regression tests here along with justification for any failing test cases. --> <!-- __ For NREL use __ Release checklist: - [ ] Update the version in hopp/__init__.py - [ ] Verify docs builds correctly - [ ] Create a tag on the main branch in the NREL/HOPP repository and push - [ ] Ensure the Test PyPI build is successful - [ ] Create a release on the main branch -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release to remove pinning
fastkml<1, and allow all releases.