Skip to content

Comments

fix: re-enable and update Playwright CI workflow#328

Open
wnykuang wants to merge 1 commit intoNatLabRockies:developfrom
wnykuang:fix/playwright-ci-290
Open

fix: re-enable and update Playwright CI workflow#328
wnykuang wants to merge 1 commit intoNatLabRockies:developfrom
wnykuang:fix/playwright-ci-290

Conversation

@wnykuang
Copy link

@wnykuang wnykuang commented Feb 7, 2026

Summary

Fixes #290 — Playwright CI tests were broken and the workflow was disabled.

Root causes and fixes:

  • Node 17 → 18: package.json requires "engines": {"node": "^18"}, but the workflow specified Node 17. Updated to Node 18.
  • Ubuntu 22.04 → 24.04: manifest.json targets Ubuntu 24.04 binaries (Ruby, MongoDB, OpenStudio). Updated the runner to match.
  • Electron system dependencies: Electron 21 requires GTK3, NSS, ALSA, and other system libraries that aren't pre-installed on Ubuntu 24.04 runners. Added explicit apt-get install step with the correct t64 package names for Noble.
  • Electron sandbox: Electron's Chrome sandbox fails on CI runners. Added --no-sandbox flag when process.env.CI is set (in playwright/App.ts).
  • Workflow triggers: Scoped from branches: "*" to develop + tags + PRs, matching the build_pat.yaml pattern.

Serial server tests skipped in CI:

The serial test suite includes integration tests that start/stop the actual OpenStudio server (MongoDB + Ruby + EnergyPlus). These require a fully configured runtime stack and time out in GitHub Actions — the stopServerTests were already skipped in CI for this reason. Extended the same !process.env.CI guard to startServerTests, serverPageTests, and runPageTests, which all depend on a running server. The saveProjectTests still runs in CI since it doesn't need the server.

Changes

  • .github/workflows/playwright.yml.disable.github/workflows/playwright.yml (re-enabled)
  • playwright/App.ts — pass --no-sandbox to Electron in CI
  • playwright/tests/serial/serial.list.ts — skip server-dependent tests in CI

Test plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playwright tests are broken

1 participant