fix: re-enable and update Playwright CI workflow#328
Open
wnykuang wants to merge 1 commit intoNatLabRockies:developfrom
Open
fix: re-enable and update Playwright CI workflow#328wnykuang wants to merge 1 commit intoNatLabRockies:developfrom
wnykuang wants to merge 1 commit intoNatLabRockies:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #290 — Playwright CI tests were broken and the workflow was disabled.
Root causes and fixes:
package.jsonrequires"engines": {"node": "^18"}, but the workflow specified Node 17. Updated to Node 18.manifest.jsontargets Ubuntu 24.04 binaries (Ruby, MongoDB, OpenStudio). Updated the runner to match.apt-get installstep with the correctt64package names for Noble.--no-sandboxflag whenprocess.env.CIis set (inplaywright/App.ts).branches: "*"todevelop+ tags + PRs, matching thebuild_pat.yamlpattern.Serial server tests skipped in CI:
The serial test suite includes integration tests that start/stop the actual OpenStudio server (MongoDB + Ruby + EnergyPlus). These require a fully configured runtime stack and time out in GitHub Actions — the
stopServerTestswere already skipped in CI for this reason. Extended the same!process.env.CIguard tostartServerTests,serverPageTests, andrunPageTests, which all depend on a running server. ThesaveProjectTestsstill runs in CI since it doesn't need the server.Changes
.github/workflows/playwright.yml.disable→.github/workflows/playwright.yml(re-enabled)playwright/App.ts— pass--no-sandboxto Electron in CIplaywright/tests/serial/serial.list.ts— skip server-dependent tests in CITest plan
saveProjectTestspasses in CI (1 passed)