Skip to content

Fix CI: Use 3.9.0 + align bundler version#156

Closed
jmarrec wants to merge 2 commits intodevelopfrom
fix-ci
Closed

Fix CI: Use 3.9.0 + align bundler version#156
jmarrec wants to merge 2 commits intodevelopfrom
fix-ci

Conversation

@jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Mar 20, 2025

@jmarrec
Copy link
Contributor Author

jmarrec commented Mar 20, 2025

Jenkins is still trying to use 2.1.4, and I have no control over it.

The tests are failling on github CI, but that's no related. At least they run.


Failed examples:

rspec ./spec/openstudio/workflow/workflow_analysis_epjson_spec.rb:257 # OSW Integration should run OSW with output requests file
rspec ./spec/openstudio/workflow/workflow_analysis_epjson_spec.rb:647 # OSW Integration should error out while copying html reports
rspec ./spec/openstudio/workflow/workflow_analysis_spec.rb:248 # OSW Integration should run OSW with output requests file
rspec ./spec/openstudio/workflow/workflow_analysis_spec.rb:631 # OSW Integration should error out while copying html reports

@jmarrec
Copy link
Contributor Author

jmarrec commented Mar 20, 2025

$ bundle exec rspec ./spec/openstudio/workflow/workflow_analysis_epjson_spec.rb:257 -e "OSW Integration should run OSW with output requests file"

[...]
[09:43:21.377519 DEBUG] Loading Measure from /Users/julien/Software/Others/openstudio_gems/OpenStudio-workflow-gem/spec/files/output_request_osw/measures/openstudio_results/measure.rb
[09:43:21.414421 ERROR] /Users/julien/Software/Others/openstudio_gems/OpenStudio-workflow-gem/lib/openstudio/workflow/util/measure.rb failed with message cannot load such file -- openstudio-standards in <internal:/Users/julien/.rvm/rubies/ruby-3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'

@jmarrec jmarrec requested a review from kflemin March 20, 2025 09:07
Comment on lines +29 to +37
s.add_development_dependency 'json-schema', '~> 4'
s.add_development_dependency 'openstudio_measure_tester', '~> 0.4.0'
s.add_development_dependency 'parallel', '~> 1.19.1'
s.add_development_dependency 'public_suffix', '~> 4.0.3'
s.add_development_dependency 'rainbow', '~> 3.0.0'
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'rspec', '~> 3.9'
s.add_development_dependency 'openstudio-standards', '~> 0.7.0'
s.add_development_dependency 'zip', '~> 2'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed openstudio-standards for the tests that use measures that use it.

@brianlball brianlball self-requested a review April 29, 2025 17:59
@brianlball
Copy link
Contributor

incorporated into #157

@brianlball brianlball closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants